Skip to content

Commit b41a6d2

Browse files
committed
feat(no-await-sync-events): add to DOM, Angular & React configs by default
BREAKING CHANGE: `no-await-sync-events` is now enabled by default in the DOM, Angular & React configs
1 parent e394ce0 commit b41a6d2

File tree

6 files changed

+10
-4
lines changed

6 files changed

+10
-4
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ To enable this configuration use the `extends` property in your
210210
| [`await-async-query`](./docs/rules/await-async-query.md) | Enforce promises from async queries to be handled | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |
211211
| [`await-async-utils`](./docs/rules/await-async-utils.md) | Enforce promises from async utils to be awaited properly | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |
212212
| [`consistent-data-testid`](./docs/rules/consistent-data-testid.md) | Ensures consistent usage of `data-testid` | | |
213-
| [`no-await-sync-events`](./docs/rules/no-await-sync-events.md) | Disallow unnecessary `await` for sync events | | |
213+
| [`no-await-sync-events`](./docs/rules/no-await-sync-events.md) | Disallow unnecessary `await` for sync events | | ![dom-badge][] ![angular-badge][] ![react-badge][] |
214214
| [`no-await-sync-query`](./docs/rules/no-await-sync-query.md) | Disallow unnecessary `await` for sync queries | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |
215215
| [`no-container`](./docs/rules/no-container.md) | Disallow the use of `container` methods | | ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |
216216
| [`no-debugging-utils`](./docs/rules/no-debugging-utils.md) | Disallow the use of debugging utilities like `debug` | | ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |

lib/configs/angular.ts

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ export = {
1111
],
1212
'testing-library/await-async-query': 'error',
1313
'testing-library/await-async-utils': 'error',
14+
'testing-library/no-await-sync-events': 'error',
1415
'testing-library/no-await-sync-query': 'error',
1516
'testing-library/no-container': 'error',
1617
'testing-library/no-debugging-utils': 'warn',

lib/configs/dom.ts

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ export = {
1111
],
1212
'testing-library/await-async-query': 'error',
1313
'testing-library/await-async-utils': 'error',
14+
'testing-library/no-await-sync-events': 'error',
1415
'testing-library/no-await-sync-query': 'error',
1516
'testing-library/no-global-regexp-flag-in-query': 'error',
1617
'testing-library/no-node-access': 'error',

lib/configs/react.ts

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ export = {
1111
],
1212
'testing-library/await-async-query': 'error',
1313
'testing-library/await-async-utils': 'error',
14+
'testing-library/no-await-sync-events': 'error',
1415
'testing-library/no-await-sync-query': 'error',
1516
'testing-library/no-container': 'error',
1617
'testing-library/no-debugging-utils': 'warn',

lib/rules/no-await-sync-events.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ export default createTestingLibraryRule<Options, MessageIds>({
2525
docs: {
2626
description: 'Disallow unnecessary `await` for sync events',
2727
recommendedConfig: {
28-
dom: false,
29-
angular: false,
30-
react: false,
28+
dom: 'error',
29+
angular: 'error',
30+
react: 'error',
3131
vue: false,
3232
marko: false,
3333
},

tests/__snapshots__/index.test.ts.snap

+3
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ Object {
1515
],
1616
"testing-library/await-async-query": "error",
1717
"testing-library/await-async-utils": "error",
18+
"testing-library/no-await-sync-events": "error",
1819
"testing-library/no-await-sync-query": "error",
1920
"testing-library/no-container": "error",
2021
"testing-library/no-debugging-utils": "warn",
@@ -50,6 +51,7 @@ Object {
5051
],
5152
"testing-library/await-async-query": "error",
5253
"testing-library/await-async-utils": "error",
54+
"testing-library/no-await-sync-events": "error",
5355
"testing-library/no-await-sync-query": "error",
5456
"testing-library/no-global-regexp-flag-in-query": "error",
5557
"testing-library/no-node-access": "error",
@@ -116,6 +118,7 @@ Object {
116118
],
117119
"testing-library/await-async-query": "error",
118120
"testing-library/await-async-utils": "error",
121+
"testing-library/no-await-sync-events": "error",
119122
"testing-library/no-await-sync-query": "error",
120123
"testing-library/no-container": "error",
121124
"testing-library/no-debugging-utils": "warn",

0 commit comments

Comments
 (0)