Skip to content

Commit d0d0df5

Browse files
authored
feat(no-global-regexp-flag-in-query): enable by default (#660)
1 parent 21504bf commit d0d0df5

File tree

8 files changed

+16
-6
lines changed

8 files changed

+16
-6
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ To enable this configuration use the `extends` property in your
215215
| [`no-container`](./docs/rules/no-container.md) | Disallow the use of `container` methods | | ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |
216216
| [`no-debugging-utils`](./docs/rules/no-debugging-utils.md) | Disallow the use of debugging utilities like `debug` | | ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |
217217
| [`no-dom-import`](./docs/rules/no-dom-import.md) | Disallow importing from DOM Testing Library | 🔧 | ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |
218-
| [`no-global-regexp-flag-in-query`](./docs/rules/no-global-regexp-flag-in-query.md) | Disallow the use of the global RegExp flag (/g) in queries | 🔧 | |
218+
| [`no-global-regexp-flag-in-query`](./docs/rules/no-global-regexp-flag-in-query.md) | Disallow the use of the global RegExp flag (/g) in queries | 🔧 | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |
219219
| [`no-manual-cleanup`](./docs/rules/no-manual-cleanup.md) | Disallow the use of `cleanup` | | ![react-badge][] ![vue-badge][] |
220220
| [`no-node-access`](./docs/rules/no-node-access.md) | Disallow direct Node access | | ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |
221221
| [`no-promise-in-fire-event`](./docs/rules/no-promise-in-fire-event.md) | Disallow the use of promises passed to a `fireEvent` method | | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |

lib/configs/angular.ts

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ export = {
1111
'testing-library/no-container': 'error',
1212
'testing-library/no-debugging-utils': 'error',
1313
'testing-library/no-dom-import': ['error', 'angular'],
14+
'testing-library/no-global-regexp-flag-in-query': 'error',
1415
'testing-library/no-node-access': 'error',
1516
'testing-library/no-promise-in-fire-event': 'error',
1617
'testing-library/no-render-in-lifecycle': 'error',

lib/configs/dom.ts

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ export = {
88
'testing-library/await-async-query': 'error',
99
'testing-library/await-async-utils': 'error',
1010
'testing-library/no-await-sync-query': 'error',
11+
'testing-library/no-global-regexp-flag-in-query': 'error',
1112
'testing-library/no-promise-in-fire-event': 'error',
1213
'testing-library/no-wait-for-empty-callback': 'error',
1314
'testing-library/no-wait-for-multiple-assertions': 'error',

lib/configs/marko.ts

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export = {
1212
'testing-library/no-container': 'error',
1313
'testing-library/no-debugging-utils': 'error',
1414
'testing-library/no-dom-import': ['error', 'marko'],
15+
'testing-library/no-global-regexp-flag-in-query': 'error',
1516
'testing-library/no-node-access': 'error',
1617
'testing-library/no-promise-in-fire-event': 'error',
1718
'testing-library/no-render-in-lifecycle': 'error',

lib/configs/react.ts

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ export = {
1111
'testing-library/no-container': 'error',
1212
'testing-library/no-debugging-utils': 'error',
1313
'testing-library/no-dom-import': ['error', 'react'],
14+
'testing-library/no-global-regexp-flag-in-query': 'error',
1415
'testing-library/no-manual-cleanup': 'error',
1516
'testing-library/no-node-access': 'error',
1617
'testing-library/no-promise-in-fire-event': 'error',

lib/configs/vue.ts

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export = {
1212
'testing-library/no-container': 'error',
1313
'testing-library/no-debugging-utils': 'error',
1414
'testing-library/no-dom-import': ['error', 'vue'],
15+
'testing-library/no-global-regexp-flag-in-query': 'error',
1516
'testing-library/no-manual-cleanup': 'error',
1617
'testing-library/no-node-access': 'error',
1718
'testing-library/no-promise-in-fire-event': 'error',

lib/rules/no-global-regexp-flag-in-query.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ export default createTestingLibraryRule<Options, MessageIds>({
2121
docs: {
2222
description: 'Disallow the use of the global RegExp flag (/g) in queries',
2323
recommendedConfig: {
24-
dom: false,
25-
angular: false,
26-
react: false,
27-
vue: false,
28-
marko: false,
24+
dom: 'error',
25+
angular: 'error',
26+
react: 'error',
27+
vue: 'error',
28+
marko: 'error',
2929
},
3030
},
3131
messages: {

tests/__snapshots__/index.test.ts.snap

+5
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ Object {
1616
"error",
1717
"angular",
1818
],
19+
"testing-library/no-global-regexp-flag-in-query": "error",
1920
"testing-library/no-node-access": "error",
2021
"testing-library/no-promise-in-fire-event": "error",
2122
"testing-library/no-render-in-lifecycle": "error",
@@ -38,6 +39,7 @@ Object {
3839
"testing-library/await-async-query": "error",
3940
"testing-library/await-async-utils": "error",
4041
"testing-library/no-await-sync-query": "error",
42+
"testing-library/no-global-regexp-flag-in-query": "error",
4143
"testing-library/no-promise-in-fire-event": "error",
4244
"testing-library/no-wait-for-empty-callback": "error",
4345
"testing-library/no-wait-for-multiple-assertions": "error",
@@ -64,6 +66,7 @@ Object {
6466
"error",
6567
"marko",
6668
],
69+
"testing-library/no-global-regexp-flag-in-query": "error",
6770
"testing-library/no-node-access": "error",
6871
"testing-library/no-promise-in-fire-event": "error",
6972
"testing-library/no-render-in-lifecycle": "error",
@@ -93,6 +96,7 @@ Object {
9396
"error",
9497
"react",
9598
],
99+
"testing-library/no-global-regexp-flag-in-query": "error",
96100
"testing-library/no-manual-cleanup": "error",
97101
"testing-library/no-node-access": "error",
98102
"testing-library/no-promise-in-fire-event": "error",
@@ -124,6 +128,7 @@ Object {
124128
"error",
125129
"vue",
126130
],
131+
"testing-library/no-global-regexp-flag-in-query": "error",
127132
"testing-library/no-manual-cleanup": "error",
128133
"testing-library/no-node-access": "error",
129134
"testing-library/no-promise-in-fire-event": "error",

0 commit comments

Comments
 (0)