Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report act from react-test-renderer #494

Open
Belco90 opened this issue Oct 3, 2021 · 1 comment
Open

Report act from react-test-renderer #494

Belco90 opened this issue Oct 3, 2021 · 1 comment
Labels
enhancement New feature or request pinned Pinned for different reasons. Issues with this label won't be flagged as stale by stalebot

Comments

@Belco90
Copy link
Member

Belco90 commented Oct 3, 2021

What rule do you want to change?

no-unnecessary-act

Does this change cause the rule to produce more or fewer warnings?

More warnings

How will the change be implemented?

As discussed in #488 the act method from react-test-renderer must be reported too.

Example code

import { act } from "react-test-renderer";
import { fireEvent } from "@testing-library/react-native";

act(() => {
     ...fireEvent..
})

How does the current rule affect the code?

act is not reported since it's imported from react-test-renderer

How will the new rule affect the code?

act imported from react-test-renderer should be reported too.

Anything else?

No response

Do you want to submit a pull request to change the rule?

Yes

@Belco90 Belco90 added the enhancement New feature or request label Oct 3, 2021
@Belco90 Belco90 self-assigned this Oct 3, 2021
@stale
Copy link

stale bot commented Dec 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 2, 2021
@Belco90 Belco90 added pinned Pinned for different reasons. Issues with this label won't be flagged as stale by stalebot and removed wontfix This will not be worked on labels Dec 2, 2021
@Belco90 Belco90 removed their assignment Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned Pinned for different reasons. Issues with this label won't be flagged as stale by stalebot
Projects
None yet
Development

No branches or pull requests

1 participant