Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

☂️ Changes for the next major (v6) #571

Closed
14 tasks done
Belco90 opened this issue Apr 17, 2022 · 3 comments
Closed
14 tasks done

☂️ Changes for the next major (v6) #571

Belco90 opened this issue Apr 17, 2022 · 3 comments
Assignees
@Belco90
Labels
BREAKING CHANGE This change will require a major version bump enhancement New feature or request pinned Pinned for different reasons. Issues with this label won't be flagged as stale by stalebot

Comments

@Belco90
Copy link
Member

Belco90 commented Apr 17, 2022 •
edited
Loading

⚠️ WIP: Pending to ellaborate more on each point

This is just an umbrella ticket for keeping track of breaking changes for the next major version (v6):

  • Drop support for node v12, which reaches EOL in 2022-04-30, and node v17, which reaches EOL in 2022-06-01
  • Enable no-manual-cleanup in React and Vue shareable configs (we don't know if the test runner in the codebase has the necessary setup hooks tho, so it could be risky)
  • Enable no-global-regexp-flag-in-query in all shareable configs
  • Enable no-await-sync-events in DOM, Angular and React shareable configs
  • Enable no-node-access in DOM shareable config
  • Enable reporting all methods by default in no-debugging-utils
  • Change error level for no-debugging-utils from "error" to "warning"
  • Make rules naming consistent (pending rules rename from v5)
  • Update internal helpers for considering the new React Testing Library renderHook util
  • Update internal helpers for considering the new async and setup behavior of user-event v14
  • Rename no-render-in-setup to no-render-in-lifecycle so it's not confused with preventing renders nested in a setup function.
  • Transform await-fire-event into await-async-events
  • Remove prefer-wait-for rule, since wait, waitForElement and waitForDomChange have been removed already
  • Drop support for <framework>-testing-library modules, in favor of supporting only the testing-library scoped format (except for Marko)
@Belco90 Belco90 added enhancement New feature or request BREAKING CHANGE This change will require a major version bump labels Apr 17, 2022
@Belco90 Belco90 self-assigned this Apr 17, 2022
@Belco90 Belco90 pinned this issue Apr 17, 2022
@Belco90 Belco90 added the pinned Pinned for different reasons. Issues with this label won't be flagged as stale by stalebot label May 6, 2022
@hjoelh
Copy link

hjoelh commented May 26, 2022

await-async-events 👌 Just wasted some time not knowing userEvents are async 😫

@Belco90
Copy link
Member Author

Belco90 commented May 26, 2022

Just wasted some time not knowing userEvents are async 😫

Sorry to hear that! They are async only from v14 tho, they were sync before such version. We updated no-await-sync-events to reflect this, but we need to convert await-fire-event into await-async-events too.

@Belco90
Copy link
Member Author

Belco90 commented Aug 4, 2022

Closing in favor of proper GitHub Project: https://github.com/orgs/testing-library/projects/14/views/1

@Belco90 Belco90 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 4, 2022
@Belco90 Belco90 unpinned this issue Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Belco90 Belco90

Labels
BREAKING CHANGE This change will require a major version bump enhancement New feature or request pinned Pinned for different reasons. Issues with this label won't be flagged as stale by stalebot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Belco90 @hjoelh