Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable no-manual-cleanup in corresponding shareable configs #617

Closed
Belco90 opened this issue Aug 4, 2022 · 0 comments · Fixed by #659
Closed

Enable no-manual-cleanup in corresponding shareable configs #617

Belco90 opened this issue Aug 4, 2022 · 0 comments · Fixed by #659
Labels
BREAKING CHANGE This change will require a major version bump v6 Next major v6

Comments

@Belco90
Copy link
Member

Belco90 commented Aug 4, 2022

Enable no-manual-cleanup in React and Vue shareable configs (we don't know if the test runner in the codebase has the necessary setup hooks tho, so it could be risky)
@MichaelDeBoey MichaelDeBoey changed the title Enable no-manual-cleanup in corresponding shareable configs Enable no-manual-cleanup in corresponding shareable configs Aug 4, 2022
@Belco90 Belco90 added v6 Next major v6 BREAKING CHANGE This change will require a major version bump labels Aug 4, 2022
@skovy skovy mentioned this issue Oct 1, 2022
Merged
3 tasks
@Belco90 Belco90 closed this as completed Oct 2, 2022
Repository owner moved this from Todo to Done in eslint-plugin-testing-library v6 Oct 2, 2022
@MichaelDeBoey MichaelDeBoey linked a pull request Oct 4, 2022 that will close this issue
feat(no-manual-cleanup): enable by default in React and Vue #659
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BREAKING CHANGE This change will require a major version bump v6 Next major v6
Projects
No open projects
eslint-plugin-testing-library v6
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(no-manual-cleanup): enable by default in React and Vue
1 participant
@Belco90