Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename no-render-in-setup to no-render-in-lifecycle #649

Merged
merged 1 commit into from
Sep 20, 2022
Merged

feat: rename no-render-in-setup to no-render-in-lifecycle #649

merged 1 commit into from
Sep 20, 2022

Conversation

skovy
Copy link
Collaborator

@skovy skovy commented Sep 20, 2022

BREAKING CHANGE: rename no-render-in-setup to no-render-in-lifecycle

Checks

  • I have read the contributing guidelines.
  • If some rule is added/updated/removed, I've regenerated the rules list (npm run generate:rules-list)
  • If some rule meta info is changed, I've regenerated the plugin shared configs (npm run generate:configs)

Changes

Context

Resolves #625.

BREAKING CHANGE: rename no-render-in-setup to no-render-in-lifecycle
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

@Belco90 Belco90 merged commit 1c7be3b into testing-library:alpha Sep 20, 2022
@MichaelDeBoey MichaelDeBoey changed the title fix: rename no-render-in-setup to no-render-in-lifecycle feat: rename no-render-in-setup to no-render-in-lifecycle Sep 20, 2022
@MichaelDeBoey MichaelDeBoey added the v6 Next major v6 label Sep 20, 2022
@github-actions
Copy link

🎉 This PR is included in version 6.0.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MichaelDeBoey MichaelDeBoey linked an issue Sep 20, 2022 that may be closed by this pull request
@skovy skovy deleted the pr/rename-no-render-in-setup-to-lifecycle branch September 20, 2022 20:00
@MichaelDeBoey MichaelDeBoey added the BREAKING CHANGE This change will require a major version bump label Oct 4, 2022
MichaelDeBoey pushed a commit that referenced this pull request Oct 4, 2022
BREAKING CHANGE: `no-render-in-setup` is now called `no-render-in-lifecycle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump released on @alpha v6 Next major v6
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Rename no-render-in-setup
3 participants