-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(await-async-events): improve fixer #675
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoa, that was quick! Everything looks fine, but I would like to ask for some more tests:
- An invalid test case where the outer test already has the
async
operator, so we test is respected - An invalid test case where there is no outer function (i.e. just a separate async event method not awaited), so we test the fixer doesn't crash if no outer function is found
This should exist in several of the tests. I noticed the diff is a bit hard to read the way it's summarized so it might need to be expanded.
Good point. Will do. |
e1f3639
to
e33ea7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for sorting it out so quick!
e33ea7b
to
d3ef713
Compare
I updated the fixer logic to only add an
This should never happen in practice, and if it does, we'll ignore it instead of being potentially syntactically incorrect. |
🎉 This PR is included in version 6.0.0-alpha.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
await-async-events
to also add missingasync
keyword to wrapping function expressionContext
Resolves #674