Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive for testing-library/await-async-events when returning using a ternary #887

Closed
jasonblalock opened this issue Mar 5, 2024 · 1 comment · Fixed by #890
Closed
Labels
bug Something isn't working released triage Pending to be triaged by a maintainer

Comments

@jasonblalock
Copy link

Have you read the Troubleshooting section?

Yes

Plugin version

v6.2.0

ESLint version

v8.56.0

Node.js version

20.11.1

package manager and version

yarn 3.2.2

Operating system

macOS Ventura 13.6.4

Bug description

Ternary return of userEvent.type or userEvent.clear is reporting testing-library/await-async-queries, even though the query will get awaited

Steps to reproduce

  1. Go to test file
  2. Add code like
async function changeEmailInput(value) {
	const emailInput = screen.getByRole('textbox', { name: 'Email' });

	return value.length
		? userEvent.type(emailInput, value)
		: userEvent.clear(emailInput);
}
  1. Observe errors on the last two lines

Promise returned from async event method type must be handled eslint testing-library/await-async-events
Promise returned from async event method clear must be handled eslint testing-library/await-async-events

Error output/screenshots

No response

ESLint configuration

{
  ...,
  plugins: [
     ...,
     'eslint-plugin-testing-library'
  ],
  rules: {
    ...,
    'testing-library/await-async-queries': ['error', { eventModule: 'userEvent' }]
  }
}

### Rule(s) affected

testing-library/await-async-queries

### Anything else?

_No response_

### Do you want to submit a pull request to fix this bug?

No
@jasonblalock jasonblalock added bug Something isn't working triage Pending to be triaged by a maintainer labels Mar 5, 2024
Copy link

🎉 This issue has been resolved in version 6.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released triage Pending to be triaged by a maintainer
Projects
None yet
1 participant