-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for flat config #923
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #923 +/- ##
==========================================
+ Coverage 96.23% 96.32% +0.08%
==========================================
Files 44 44
Lines 2419 2449 +30
Branches 1000 1018 +18
==========================================
+ Hits 2328 2359 +31
+ Misses 91 90 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding flat config support in the current version ❤️
🎉 This PR is included in version 6.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Checks
Changes
Context
Resolves #902
Resolves #853
This uses a very similar approach to what I'm using for
eslint-plugin-jest
- the types should actually be pretty much correct, but I've just gone straight to casting since things are a bit of a mess right now ecosystem wise, which'll improve once we have everyone on ESLint v9.Similarly I've not worried about adding any particular tests since the output is pretty stable and easily validated manually (which I have already), and I've based the documentation off what we use in
eslint-plugin-jest
too