Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): update to @typescript-eslint/* v6 #945

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Oct 19, 2024

First part of migration to latest typescript-eslint version

CC/ @G-Rath @JoshuaKGoldberg


Closes #946

@MichaelDeBoey MichaelDeBoey added the v7 Next major v7 label Oct 19, 2024
@MichaelDeBoey MichaelDeBoey requested a review from Belco90 October 19, 2024 04:14
Copy link
Contributor

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this!

@Belco90
Copy link
Member

Belco90 commented Oct 30, 2024

All tests are failing, can you take a look @MichaelDeBoey ?

@MichaelDeBoey MichaelDeBoey force-pushed the update-to-typescript_eslint-v6 branch from 49ee565 to 00682e5 Compare October 30, 2024 14:00
@MichaelDeBoey MichaelDeBoey force-pushed the update-to-typescript_eslint-v6 branch from 00682e5 to a27659c Compare October 30, 2024 14:36
@MichaelDeBoey MichaelDeBoey requested a review from Belco90 October 30, 2024 14:37
@Belco90 Belco90 merged commit f07ee64 into beta Oct 30, 2024
26 checks passed
@Belco90 Belco90 deleted the update-to-typescript_eslint-v6 branch October 30, 2024 15:05
Copy link

🎉 This PR is included in version 7.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@@ -51,7 +51,8 @@
"type-check": "tsc --noEmit"
},
"dependencies": {
"@typescript-eslint/utils": "^5.62.0"
"@typescript-eslint/scope-manager": "^6.21.0",
"@typescript-eslint/utils": "^6.21.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be:

"@typescript-eslint/utils": "^8.12.0"

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because this pull request is upgrading them to v6, not v8

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I see there is a #947 v7 and presumably v8 will happen at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

Used version of @typescript-eslint/utils does not support ESLint v9
4 participants