From 6707e14bdf811061a43e71be9339d4792a3edeed Mon Sep 17 00:00:00 2001 From: Dmitry Drozdov Date: Thu, 7 Nov 2024 15:03:43 +0300 Subject: [PATCH 1/2] feat(prefer-user-event): add support for React Native events Closes #957 --- docs/rules/prefer-user-event.md | 3 +++ lib/rules/prefer-user-event.ts | 5 +++++ 2 files changed, 8 insertions(+) diff --git a/docs/rules/prefer-user-event.md b/docs/rules/prefer-user-event.md index 421a0875..932f5847 100644 --- a/docs/rules/prefer-user-event.md +++ b/docs/rules/prefer-user-event.md @@ -138,3 +138,6 @@ The following table lists all the possible equivalents from the low-level API `f | `pointerOut` | | | `pointerOver` | | | `pointerUp` | | +| `press` | | +| `scroll` | | +| `type` | | diff --git a/lib/rules/prefer-user-event.ts b/lib/rules/prefer-user-event.ts index daf408d1..1fe6197c 100644 --- a/lib/rules/prefer-user-event.ts +++ b/lib/rules/prefer-user-event.ts @@ -24,6 +24,8 @@ export const UserEventMethods = [ 'hover', 'unhover', 'paste', + 'press', + 'scrollTo', ] as const; type UserEventMethodsType = (typeof UserEventMethods)[number]; @@ -51,6 +53,9 @@ export const MAPPING_TO_USER_EVENT: Record = { pointerOut: ['unhover'], pointerOver: ['hover', 'selectOptions', 'deselectOptions'], pointerUp: ['click', 'dblClick', 'selectOptions', 'deselectOptions'], + press: ['press'], + scroll: ['scrollTo'], + type: ['type'], }; function buildErrorMessage(fireEventMethod: string) { From 02dc49ec17f8236bfeda824ad45cb11d89f223bf Mon Sep 17 00:00:00 2001 From: Dmitry Drozdov Date: Thu, 7 Nov 2024 15:21:31 +0300 Subject: [PATCH 2/2] feat(prefer-user-event): fix typo --- docs/rules/prefer-user-event.md | 2 +- lib/rules/prefer-user-event.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/rules/prefer-user-event.md b/docs/rules/prefer-user-event.md index 932f5847..d0df0434 100644 --- a/docs/rules/prefer-user-event.md +++ b/docs/rules/prefer-user-event.md @@ -118,6 +118,7 @@ The following table lists all the possible equivalents from the low-level API `f | ---------------- | ----------------------------------------------------------------------------------------------------------- | | `click` |
  • `click`
  • `type`
  • `selectOptions`
  • `deselectOptions`
| | `change` |
  • `upload`
  • `type`
  • `clear`
  • `selectOptions`
  • `deselectOptions`
| +| `changeText` |
  • `type`
| | `dblClick` |
  • `dblClick`
| | `input` |
  • `type`
  • `upload`
  • `selectOptions`
  • `deselectOptions`
  • `paste`
| | `keyDown` |
  • `type`
  • `tab`
| @@ -140,4 +141,3 @@ The following table lists all the possible equivalents from the low-level API `f | `pointerUp` |
  • `click`
  • `dblClick`
  • `selectOptions`
  • `deselectOptions`
| | `press` |
  • `press`
| | `scroll` |
  • `scrollTo`
| -| `type` |
  • `type`
| diff --git a/lib/rules/prefer-user-event.ts b/lib/rules/prefer-user-event.ts index 1fe6197c..ccfeb435 100644 --- a/lib/rules/prefer-user-event.ts +++ b/lib/rules/prefer-user-event.ts @@ -33,6 +33,7 @@ type UserEventMethodsType = (typeof UserEventMethods)[number]; export const MAPPING_TO_USER_EVENT: Record = { click: ['click', 'type', 'selectOptions', 'deselectOptions'], change: ['upload', 'type', 'clear', 'selectOptions', 'deselectOptions'], + changeText: ['type'], dblClick: ['dblClick'], input: ['type', 'upload', 'selectOptions', 'deselectOptions', 'paste'], keyDown: ['type', 'tab'], @@ -55,7 +56,6 @@ export const MAPPING_TO_USER_EVENT: Record = { pointerUp: ['click', 'dblClick', 'selectOptions', 'deselectOptions'], press: ['press'], scroll: ['scrollTo'], - type: ['type'], }; function buildErrorMessage(fireEventMethod: string) {