Skip to content

Commit 6015c05

Browse files
brianlu2610Brian Lu
and
Brian Lu
authored
fix(a11y): underline links in a text block as pur WCAG 2.0 (#1449)
* fix(a11y): underline links surrounded by text * chore(name): updating class name to be clearer --------- Co-authored-by: Brian Lu <[email protected]>
1 parent 6dc5985 commit 6015c05

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

src/css/custom.css

+9-5
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33
}
44

55
[data-theme='dark']:root {
6-
--ifm-color-primary: #7FA8F1;
7-
--ifm-link-color: #7FA8F1;
6+
--ifm-color-primary: #7fa8f1;
7+
--ifm-link-color: #7fa8f1;
88
--docsearch-muted-color: white;
99
}
1010

1111
[data-theme='light']:root {
12-
--ifm-color-primary: #1554B7;
13-
--ifm-link-color: #1554B7;
14-
--docsearch-muted-color: #494B5F;
12+
--ifm-color-primary: #1554b7;
13+
--ifm-link-color: #1554b7;
14+
--docsearch-muted-color: #494b5f;
1515
}
1616

1717
.wrapper {
@@ -483,6 +483,10 @@ details.alert div {
483483
padding-top: 0;
484484
}
485485

486+
.textBlockWithLinks a {
487+
text-decoration: underline;
488+
}
489+
486490
@media only screen and (min-width: 1024px) {
487491
.projectTitle {
488492
margin-top: 80px;

src/pages/help.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -64,18 +64,20 @@ export default function Help(props) {
6464
<h1 className="help-heading-1">Need help?</h1>
6565
</header>
6666
<GridBlock
67+
className="textBlockWithLinks"
6768
contents={supportLinks.slice(0, 3)}
6869
layout="threeColumn"
6970
align="left"
7071
/>
7172
<GridBlock
73+
className="textBlockWithLinks"
7274
contents={supportLinks.slice(3)}
7375
layout="threeColumn"
7476
align="left"
7577
/>
7678
<section>
7779
<h2 className="help-heading-2">Buy a course</h2>
78-
<p>
80+
<p className="textBlockWithLinks">
7981
Learn how to test JavaScript with{' '}
8082
<ExternalLink href="https://kentcdodds.com">
8183
Kent C. Dodds
@@ -105,7 +107,7 @@ export default function Help(props) {
105107
community successful and improve tests for everyone in the long
106108
run.
107109
</p>
108-
<p>
110+
<p className="textBlockWithLinks">
109111
Please consider helping us answer community questions and update
110112
documentation content via the help links above. You can also help
111113
support{' '}

0 commit comments

Comments
 (0)