Skip to content

Commit 5d8373a

Browse files
committedOct 2, 2018
tools,gyp: don't force build actions with multiple outputs
Don't add `force_append` (FORCE_DO_CMD) to the intermediate sentinal. Adding it makes the action run alway, even when there are no changes. (refack): AFAICT because `*.intermediate` files don't have build rules. PR-URL: nodejs#23156 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
1 parent 731a72f commit 5d8373a

File tree

1 file changed

+4
-2
lines changed
  • tools/gyp/pylib/gyp/generator

1 file changed

+4
-2
lines changed
 

‎tools/gyp/pylib/gyp/generator/make.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -1758,8 +1758,10 @@ def WriteMakeRule(self, outputs, inputs, actions=None, comment=None,
17581758
self.WriteLn('%s: %s' % (' '.join(outputs), intermediate))
17591759
self.WriteLn('\t%s' % '@:')
17601760
self.WriteLn('%s: %s' % ('.INTERMEDIATE', intermediate))
1761-
self.WriteLn('%s: %s%s' %
1762-
(intermediate, ' '.join(inputs), force_append))
1761+
# Don't add `force_append` (FORCE_DO_CMD) to the intermediate sentinal.
1762+
# Adding it makes the action run alway, even when there are no changes.
1763+
# (refack): AFAICT because `*.intermediate` files don't have build rules.
1764+
self.WriteLn('%s: %s' % (intermediate, ' '.join(inputs)))
17631765
actions.insert(0, '$(call do_cmd,touch)')
17641766

17651767
if actions:

0 commit comments

Comments
 (0)
Please sign in to comment.