Skip to content

Commit 52e2373

Browse files
committed
Fix #333
1 parent e5f0ee9 commit 52e2373

File tree

1 file changed

+15
-6
lines changed

1 file changed

+15
-6
lines changed

src/generator/enricher/phpunit/PHPUnit.php

+15-6
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,19 @@
1313
class PHPUnit extends AbstractEnricher implements
1414
EndEnricherInterface, ClassEnricherInterface, TraitEnricherInterface, TokenFileEnricherInterface {
1515

16-
const XMLNS = 'http://schema.phpunit.de/coverage/1.0';
16+
const XMLNS_HTTP = 'http://schema.phpunit.de/coverage/1.0';
17+
const XMLNS_HTTPS = 'https://schema.phpunit.de/coverage/1.0';
1718

1819
/**
1920
* @var Fileinfo
2021
*/
2122
private $coveragePath;
2223

24+
/**
25+
* @var string
26+
*/
27+
private $namespaceURI;
28+
2329
/**
2430
* @var FileInfo
2531
*/
@@ -63,7 +69,7 @@ public function enrichEnd(PHPDoxEndEvent $event) {
6369
}
6470
/** @var fDOMElement $classNode */
6571
$container = $this->getEnrichtmentContainer($classNode, 'phpunit');
66-
$resultNode = $container->appendElementNS(self::XMLNS, 'result');
72+
$resultNode = $container->appendElementNS($this->namespaceURI, 'result');
6773
foreach($results as $key => $value) {
6874
$resultNode->setAttribute(mb_strtolower($key), $value);
6975
}
@@ -125,13 +131,16 @@ private function loadXML($fname) {
125131
$dom = new fDOMDocument();
126132
$dom->load($fname);
127133

128-
if ($dom->documentElement->namespaceURI != self::XMLNS) {
134+
$this->namespaceURI = $dom->documentElement->namespaceURI;
135+
136+
if (!in_array($this->namespaceURI, [self::XMLNS_HTTP, self::XMLNS_HTTPS])) {
129137
throw new EnricherException(
130138
'Wrong namspace - not a PHPUnit code coverage file',
131139
EnricherException::LoadError
132140
);
133141
}
134-
$dom->registerNamespace('pu', self::XMLNS);
142+
143+
$dom->registerNamespace('pu', $this->namespaceURI);
135144

136145
return $dom;
137146
} catch (fDOMException $e) {
@@ -156,7 +165,7 @@ private function processUnit(fDOMDocument $unit, fDOMDocument $coverage) {
156165
// This class seems to be newer than the last phpunit run
157166
return;
158167
}
159-
$coverageTarget = $enrichment->appendElementNS(self::XMLNS, 'coverage');
168+
$coverageTarget = $enrichment->appendElementNS($this->namespaceURI, 'coverage');
160169
foreach(array('executable','executed', 'crap') as $attr) {
161170
$coverageTarget->appendChild(
162171
$coverageTarget->ownerDocument->importNode($classNode->getAttributeNode($attr))
@@ -181,7 +190,7 @@ private function processUnit(fDOMDocument $unit, fDOMDocument $coverage) {
181190
$end = $method->getAttribute('end');
182191

183192
$enrichment = $this->getEnrichtmentContainer($method, 'phpunit');
184-
$coverageTarget = $enrichment->appendElementNS(self::XMLNS, 'coverage');
193+
$coverageTarget = $enrichment->appendElementNS($this->namespaceURI, 'coverage');
185194

186195
/** @var fDOMElement $coverageMethod */
187196
$coverageMethod = $coverage->queryOne(

0 commit comments

Comments
 (0)