Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git enricher does not work properly with Git 1.7.1 #325

Closed
sebastianbergmann opened this issue Jan 24, 2018 · 3 comments
Closed

Git enricher does not work properly with Git 1.7.1 #325

sebastianbergmann opened this issue Jan 24, 2018 · 3 comments

Comments

@sebastianbergmann
Copy link
Contributor

When I run

$ git clone https://github.com/sebastianbergmann/phpunit.git

$ cd phpunit

$ ant generate-project-documentation

on a system that has Git 1.7.1 then the Git enricher leaves the %B placeholder in the generated output.

If I run the same on a system that has Git 2.14.3 then the Git enricher produces useful output.

@theseer
Copy link
Owner

theseer commented Jan 24, 2018

According to this commit to git, it seems %B is available since 1.7.2-rc0 which would make it a close miss for your version.

As that commit and version is about 7 years old, I'm not sure if I should still add support for it?

@theseer
Copy link
Owner

theseer commented Jan 24, 2018

I guess I'll declare git < 1.7.2 as unsupported. I might add a check for that into the git enricher.

@sebastianbergmann
Copy link
Contributor Author

Makes sense.

@theseer theseer closed this as completed in b907cb0 May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants