Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude does nothing #66

Closed
williamjulianvicary opened this issue Apr 20, 2012 · 5 comments
Closed

Exclude does nothing #66

williamjulianvicary opened this issue Apr 20, 2012 · 5 comments

Comments

@williamjulianvicary
Copy link

When trying to add exclude paths it doesn't appear to have an affect on the output I've tried all different exclude masks I could think of, including altering the include mask to an exclude without effect - this document is definitely being included as I can break it by adding rubbish to it.

<phpdox xmlns="http://phpdox.de/config">
 <project name="Project X" source="src" workdir="build/phpdox">
  <collector publiconly="false">
   <include mask="*.php" />
   <exclude mask="**external**" />
  </collector>

  <generator output="build">
   <build engine="html" enabled="true" output="api"/>
  </generator>
 </project>
</phpdox>
@theseer
Copy link
Owner

theseer commented Apr 26, 2012

I finally had some time to try to reproduce your problem, but I cannot on my development version.
The logic behind the filter is a simple fnmatch function call btw..

theseer@rikka ~/storage/php/phpdox master $ grep "exclude" phpdox.xml.dist && ./phpdox.php

phpdox %development% - Copyright (C) 2010 - 2012 by Arne Blankerts

[...]

cccccccccccccccccccccccccccccccccccccccccccc [44]

versus

theseer@rikka ~/storage/php/phpdox master $ grep "exclude" phpdox.xml.dist && ./phpdox.php

phpdox %development% - Copyright (C) 2010 - 2012 by Arne Blankerts

[...]

cccccccccccccccccccccccccccccccccccccccccccccccccc [50]
ccccccc [57]

@williamjulianvicary
Copy link
Author

Hmm this is odd - it appears that the collector is excluding as expected, however when it comes to the generator it appears to scan the full data set again - the documentation this has created is full of unused classes within the /external/ folder (Zend framework and an internal library).

Is there a different exclusion protocol for the generator?

@williamjulianvicary
Copy link
Author

I think I have figured this out - is there some kind of caching involved with the generator process? Clearing my workspace in Jenkins has sorted this, using the same SVN source.

Hope this helps!

@seyfer
Copy link

seyfer commented Oct 10, 2013

@williamvicary method resolv my issue too

[https://github.com//issues/111]

@theseer
Copy link
Owner

theseer commented Feb 7, 2014

As the cache handling has been rewritten as well as the config change detection implemented, I close this ticket. If the problem remains, please open a new ticket.

@theseer theseer closed this as completed Feb 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants