From ea366247ea0d7e50edbf6bebc680784bce2c7c23 Mon Sep 17 00:00:00 2001
From: Eriksen Costa <eriksencosta@gmail.com>
Date: Fri, 23 Jan 2015 18:13:56 -0200
Subject: [PATCH] Change build state logic

It still follows the Arne Blankerts definition but was modified because
I found some issues like interfaces and empty clases being marked as
untested when they should be marked as empty.

Additionally I found some cases where test covered classes were marked
as empty because the executable lines was equal to 0 (not sure if it is
a PHP_CodeCoverage issue or a phpDox issue).

The change in the XSLT logic solves the issues above. I basically
inverted the logic statements. If there is coverage or executable lines
for the class, it will classify it between untested, failed or passed.
Otherwise, it will be classified as empty.

See: https://github.com/theseer/phpdox/issues/147#issuecomment-57431624
---
 templates/html/units.xsl | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/templates/html/units.xsl b/templates/html/units.xsl
index 94b5e1eb..0a9e55a2 100644
--- a/templates/html/units.xsl
+++ b/templates/html/units.xsl
@@ -74,10 +74,7 @@
         <xsl:param name="class" />
 
         <xsl:choose>
-            <xsl:when test="$class//pu:coverage/@executable = 0">
-                <xsl:attribute name="class">testresult-EMPTY</xsl:attribute>EMPTY</xsl:when>
-
-            <xsl:otherwise>
+            <xsl:when test="$class//pu:coverage/@coverage != 0 or $class//pu:coverage/@executable != 0">
                 <xsl:variable name="result" select="$class//pu:result" />
                 <xsl:choose>
                     <!-- all 0 or skipped or incomplete -->
@@ -91,10 +88,12 @@
                     <!-- everything 0 except passed -->
                     <xsl:when test="sum($result/@*) = $result/@passed and $result/@passed != 0">
                         <xsl:attribute name="class">testresult-PASSED</xsl:attribute>PASSED</xsl:when>
-
                 </xsl:choose>
+            </xsl:when>
+            <xsl:otherwise>
+                <!-- interfaces, empty classes and/or absence of coverage data -->
+                <xsl:attribute name="class">testresult-EMPTY</xsl:attribute>EMPTY
             </xsl:otherwise>
-
         </xsl:choose>
 
     </xsl:template>