Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom buildFolder/outDir #3

Open
mikestopcontinues opened this issue Aug 22, 2019 · 5 comments · May be fixed by #4
Open

Custom buildFolder/outDir #3

mikestopcontinues opened this issue Aug 22, 2019 · 5 comments · May be fixed by #4

Comments

@mikestopcontinues
Copy link

I'm trying to keep my local directory structure clean, and I'd like this plugin to use my custom.parcel.outDir setting, rather than the hardcoded buildFolder. It doesn't seem like a particularly big change, and I'd be happy to submit a PR if you're ok with it. Thanks!
@pavelvlasov
Copy link
Contributor

hey @mikestopcontinues! Sorry for a late reply. That sounds like a great idea, so have no objections 👍

@mikestopcontinues
Copy link
Author

Great! I'll have something soon!

@mikestopcontinues mikestopcontinues linked a pull request Sep 5, 2019 that will close this issue
Draft
@mikestopcontinues
Copy link
Author

@pavelvlasov, after looking at the code, it seems the path of least resistance is the linked PR. Basically just allowing an override of buildFolder. Is that okay with you, or would you prefer the parcel config syntax with outDir?

@pavelvlasov
Copy link
Contributor

@mikestopcontinues I would like to follow parcel config naming, so let's go with outDir. LGTM otherwise 👍

@mikestopcontinues
Copy link
Author

Hey, sorry for the delay! Been in the process of moving. I'll get to this asap!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Override hardcoded buildFolder with custom.parcel.buildFolder
2 participants
@mikestopcontinues @pavelvlasov