Improve inference in a couple of spots (#566)

xref timholy/CodeTracking.jl#73

Author: timholy

src/lowered.jl

@@ -210,10 +210,9 @@ function methods_by_execution!(@nospecialize(recurse), methodinfo, docexprs, mod
         local active_bp_refs
         if disablebp
             # We have to turn off all active breakpoints, https://github.com/timholy/CodeTracking.jl/issues/27
-            bp_refs = JuliaInterpreter.breakpoints()
-            if eltype(bp_refs) !== JuliaInterpreter.BreakpointRef
-                bp_refs = JuliaInterpreter.BreakpointRef[]
-                foreach(bp -> append!(bp_refs, bp.instances), bp_refs)
+            bp_refs = JuliaInterpreter.BreakpointRef[]
+            for bp in JuliaInterpreter.breakpoints()
+                append!(bp_refs, bp.instances)
             end
             active_bp_refs = filter(bp->bp[].isactive, bp_refs)
             foreach(disable, active_bp_refs)

src/packagedef.jl

@@ -593,8 +593,10 @@ function revise_file_queued(pkgdata::PkgData, file)
     stillwatching = true
     while stillwatching
         if !file_exists(file) && !isdir(file)
-            with_logger(SimpleLogger(stderr)) do
-                @warn "$file is not an existing file, Revise is not watching"
+            let file=file
+                with_logger(SimpleLogger(stderr)) do
+                    @warn "$file is not an existing file, Revise is not watching"
+                end
             end
             notify(revision_event)
             break
@@ -720,7 +722,7 @@ function revise(; throw=false)
 
     # Do all the deletion first. This ensures that a method that moved from one file to another
     # won't get redefined first and deleted second.
-    revision_errors = []
+    revision_errors = Tuple{PkgData,String}[]
     queue = sort!(collect(revision_queue); lt=pkgfileless)
     finished = eltype(revision_queue)[]
     mexsnews = ModuleExprsSigs[]