Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access from "Share Via" menu #34

Closed
VishnuSanal opened this issue Aug 31, 2023 · 7 comments
Closed

Access from "Share Via" menu #34

VishnuSanal opened this issue Aug 31, 2023 · 7 comments

Comments

@VishnuSanal
Copy link

Add NotificationDictionary to Android's "Share Via" menu; so that we can select a word, click on share & fetch the meaning.

PS: if you are interested in accepting this idea, I'd like to work on this :)

@tirkarthi
Copy link
Owner

Hi, thanks for the report. Just trying to understand is there any advantage to this than selecting the word and clicking on meaning in context menu as I see them having similar number of clicks and actions.

@VishnuSanal
Copy link
Author

Hi, thanks for the report. Just trying to understand is there any advantage to this than selecting the word and clicking on meaning in context menu as I see them having similar number of clicks and actions.

hmm, I was thinking of the cases when the "meaning" context item does not appear. for instance on the GMail application, on Twitter, from some kind of text box (say on WhatsApp) etc.

(CMMIW: whether it is a bug that the context item doesn't appear? is it specific to my device? 🤔)

@tirkarthi
Copy link
Owner

See also #28 and #25 . It could be that some apps implement custom select interface where meaning might not show up as is case with whatsapp where the whole message is selected and a single word from message cannot be selected. Since dictionary acts on single word it might not be useful in those cases.

@VishnuSanal
Copy link
Author

See also #28 and #25 . It could be that some apps implement custom select interface where meaning might not show up

I see. this is exactly what I meant as a use case for this feature. please note 'share' item always appeared on screen grabs provided in the tagged issues.

as is case with whatsapp where the whole message is selected and a single word from message cannot be selected. Since dictionary acts on single word it might not be useful in those cases.

I meant text fields in general; WhatsApp was used as an example! We can select single words from a text field & then click share from the context menu.

@tirkarthi
Copy link
Owner

I have added a PR for this #36 . It seems in Samsung version when the text is selected in browser like brave the URL along with selected text is also added. E.g. when test in a page is selected then "test" https://example.com is received as the intent text in the app that will result in no results.

@VishnuSanal
Copy link
Author

I have added a PR for this #36 . It seems in Samsung version when the text is selected in browser like brave the URL along with selected text is also added. E.g. when test in a page is selected then "test" https://example.com is received as the intent text in the app that will result in no results.

Let me check.

@in-plaintext
Copy link

Termux has its own or non-standard context menu — at the time there doesn't be any way to share words to Notification Dictionary, a great drawback since I mainly use the Linux environment on Android.

Thankfully a PR has been created.

@tirkarthi
Copy link
Owner

Merged as part of #36. Closing. Thanks @VishnuSanal for the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants