Skip to content

Commit af3263d

Browse files
committed
test: regression test for nodejs#5798 setImmediate
1 parent 9126f3c commit af3263d

File tree

2 files changed

+59
-5
lines changed

2 files changed

+59
-5
lines changed

doc/api/timers.markdown

+4-5
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,10 @@ callbacks and before `setTimeout` and `setInterval` . Returns an
5454
`immediateId` for possible use with `clearImmediate()`. Optionally you
5555
can also pass arguments to the callback.
5656

57-
Immediates are queued in the order created, and are popped off the queue once
58-
per loop iteration. `setImmediate` will yield to the event loop after firing a
59-
queued callback to make sure I/O is not being starved. While order is preserved
60-
for execution, other I/O events may fire between any two scheduled immediate
61-
callbacks.
57+
Callbacks for immediates are queued in the order in which they were created.
58+
The entire callback queue is processed every event loop iteration. If you queue
59+
an immediate from a inside an executing callback that immediate won't fire
60+
until the next event loop iteration.
6261

6362
## clearImmediate(immediateId)
6463

+55
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
// Copyright Joyent, Inc. and other Node contributors.
2+
//
3+
// Permission is hereby granted, free of charge, to any person obtaining a
4+
// copy of this software and associated documentation files (the
5+
// "Software"), to deal in the Software without restriction, including
6+
// without limitation the rights to use, copy, modify, merge, publish,
7+
// distribute, sublicense, and/or sell copies of the Software, and to permit
8+
// persons to whom the Software is furnished to do so, subject to the
9+
// following conditions:
10+
//
11+
// The above copyright notice and this permission notice shall be included
12+
// in all copies or substantial portions of the Software.
13+
//
14+
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
15+
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
16+
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
17+
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
18+
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
19+
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
20+
// USE OR OTHER DEALINGS IN THE SOFTWARE.
21+
22+
var common = require('../common');
23+
var assert = require('assert');
24+
25+
// setImmediate should run clear its queued cbs once per event loop turn
26+
// but immediates queued while processing the current queue should happen
27+
// on the next turn of the event loop.
28+
29+
// in v0.10 hit should be 1, because we only process one cb per turn
30+
// in v0.11 and beyond it should be the exact same size of QUEUE
31+
// if we're letting things recursively add to the immediate QUEUE hit will be
32+
// > QUEUE
33+
34+
var ticked = false;
35+
36+
var hit = 0;
37+
var QUEUE = 1000;
38+
39+
function run() {
40+
if (hit === 0)
41+
process.nextTick(function() { ticked = true; });
42+
43+
if (ticked) return;
44+
45+
hit += 1;
46+
setImmediate(run);
47+
}
48+
49+
for (var i = 0; i < QUEUE; i++)
50+
setImmediate(run);
51+
52+
process.on('exit', function() {
53+
console.log('hit', hit);
54+
assert.strictEqual(hit, QUEUE, 'We ticked between the immediate queue');
55+
});

0 commit comments

Comments
 (0)