Don't encode EAB HMAC

mholt · mholt · commit 77f91b9bbeea · 2020-06-11T15:30:56.000-06:00
Most providers already encode it
diff --git a/acmeclient.go b/acmeclient.go
@@ -17,7 +17,6 @@ package certmagic
 import (
 	"context"
 	"crypto/tls"
-	"encoding/base64"
 	"fmt"
 	"log"
 	weakrand "math/rand"
@@ -168,7 +167,7 @@ func (am *ACMEManager) newACMEClient(useTestCA, interactive bool) (*acmeClient,
 			reg, err = client.Registration.RegisterWithExternalAccountBinding(registration.RegisterEABOptions{
 				TermsOfServiceAgreed: am.Agreed,
 				Kid:                  am.ExternalAccount.KeyID,
-				HmacEncoded:          base64.StdEncoding.EncodeToString(am.ExternalAccount.HMAC),
+				HmacEncoded:          am.ExternalAccount.HMAC,
 			})
 		} else {
 			reg, err = client.Registration.Register(registration.RegisterOptions{
diff --git a/acmemanager.go b/acmemanager.go
@@ -336,7 +336,7 @@ func (am *ACMEManager) Revoke(ctx context.Context, cert CertificateResource) err
 // binding an external account to an ACME account.
 type ExternalAccountBinding struct {
 	KeyID string
-	HMAC  []byte
+	HMAC  string
 }
 
 // DefaultACME specifies the default settings

Original file line number	Diff line number	Diff line change
`@@ -336,7 +336,7 @@ func (am *ACMEManager) Revoke(ctx context.Context, cert CertificateResource) err`
`336`	`336`	`// binding an external account to an ACME account.`
`337`	`337`	`type ExternalAccountBinding struct {`
`338`	`338`	`KeyID string`
`339`		`- HMAC []byte`
	`339`	`+ HMAC string`
`340`	`340`	`}`
`341`	`341`
`342`	`342`	`// DefaultACME specifies the default settings`