You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For cases like Waiter, may we need an object to simulate shell responses perfectly for the sake of testing correct behavior of test_waiter.py
We're testing the correct behavior of Waiter
In this case, we want to be sure that in various instances, including simulated ones that are exact to real tmux use cases, waiter behaves as designed.
We want correct mocks
Examine mocking of subprocess responses. In the same way responses mocks requests, this would "tap in" at a low level, while also ensuring our existing tests using real tmux still work without any additional effort.
Maybe also permit real tests
Perhaps also allow e2e tests that use real tmux sessions in the backend too
We don't want to lose benefit of testing against real world scenarios:
Existing fuzziness cause by environments, different shells
Shell updates, OS updates
Tmux updates
The text was updated successfully, but these errors were encountered:
Problem
Waiter
(test_waiter
) flakes a lot.Proposal
For cases like
Waiter
, may we need an object to simulate shell responses perfectly for the sake of testing correct behavior oftest_waiter.py
We're testing the correct behavior of Waiter
In this case, we want to be sure that in various instances, including simulated ones that are exact to real tmux use cases, waiter behaves as designed.
We want correct mocks
Examine mocking of
subprocess
responses. In the same wayresponses
mocksrequests
, this would "tap in" at a low level, while also ensuring our existing tests using real tmux still work without any additional effort.Maybe also permit real tests
Perhaps also allow e2e tests that use real tmux sessions in the backend too
We don't want to lose benefit of testing against real world scenarios:
The text was updated successfully, but these errors were encountered: