Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: support Brotli (br) compression #281

Closed
colinskow opened this issue Jul 19, 2019 · 2 comments · Fixed by #282
Closed

Feature: support Brotli (br) compression #281

colinskow opened this issue Jul 19, 2019 · 2 comments · Fixed by #282

Comments

@colinskow
Copy link
Contributor

When a web server sends a page with Content-Encdoding: "br" (Brotli compression), Needle spits out a body of gibberish rather than properly decompressing it. NodeJS LTS supports Brotli, so it should be a no-brainer to implement.
@tomas
Copy link
Owner

tomas commented Jul 20, 2019

Sure, sounds great. Would you like to give it a shot?

@colinskow
Copy link
Contributor Author

Alright, I just took a look and it's real easy. I just need to add 'br' to the list of decompressors. I'll give it a shot over the next few days.

@colinskow colinskow mentioned this issue Jul 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support brotli compression on Node 10+ colinskow/needle
2 participants
@tomas @colinskow