Skip to content

Commit 4b651df

Browse files
committed
The latest version of splinter no longer supports phantomjs, use the default firefox driver instead.
1 parent a4974af commit 4b651df

File tree

4 files changed

+2
-17
lines changed

4 files changed

+2
-17
lines changed

geonode/tests/bdd/e2e/conftest.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,11 @@
3939
@pytest.yield_fixture(scope='function', autouse=True)
4040
def en_browser(browser, bdd_server):
4141
"""Browser login page from live server."""
42-
browser = Browser('phantomjs')
42+
browser = Browser()
4343
en_browser = browser
4444
en_browser.visit(urljoin(bdd_server.url, '/account/login/'))
4545
yield en_browser
4646
try:
47-
# kill the specific phantomjs child proc
4847
en_browser.service.process.send_signal(signal.SIGTERM)
4948
except BaseException:
5049
pass

pytest.ini

-1
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,3 @@ python_classes = *Test
44
python_functions = test_*
55
pep8maxlinelength = 79
66
testpaths = geonode/tests/bdd/e2e/
7-
addopts = --splinter-webdriver=phantomjs

requirements.txt

+1
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ flake8==3.7.7
131131
pytest==4.3.1
132132
pytest-bdd==3.1.0
133133
splinter==0.10.0
134+
pytest-splinter==2.0.1
134135
pytest-django==3.4.8
135136
setuptools==40.8.0
136137
Twisted==18.9.0

scripts/misc/bdd_setup.sh

-14
This file was deleted.

0 commit comments

Comments
 (0)