Fix missing error for tox -e unknown when tox.ini declares envlist. (#1165)

* Fix missing error for `tox -e unknown` when tox.ini declares envlist.

Fixes #1160.

* fix_lint (not just fix-lint)

Author: medmunds

docs/changelog/1160.bugfix.rst

@@ -0,0 +1 @@
+Fix missing error for ``tox -e unknown`` when tox.ini declares ``envlist``. - by :user:`medmunds`

src/tox/config/__init__.py

@@ -1053,7 +1053,7 @@ def __init__(self, config, ini_path, ini_data):  # noqa
         # factors stated in config envlist
         stated_envlist = reader.getstring("envlist", replace=False)
         if stated_envlist:
-            for env in config.envlist:
+            for env in _split_env(stated_envlist):
                 known_factors.update(env.split("-"))
 
         # configure testenvs

tests/unit/config/test_config.py

@@ -2147,6 +2147,15 @@ def test_py_venv(self, newconfig):
         env = config.envconfigs["py"]
         assert str(env.basepython) == sys.executable
 
+    def test_no_implicit_venv_from_cli_with_envlist(self, newconfig):
+        # See issue 1160.
+        inisource = """
+            [tox]
+            envlist = stated-factors
+        """
+        config = newconfig(["-etypo-factor"], inisource)
+        assert "typo-factor" not in config.envconfigs
+
     def test_correct_basepython_chosen_from_default_factors(self, newconfig):
         envlist = list(tox.PYTHON.DEFAULT_FACTORS.keys())
         config = newconfig([], "[tox]\nenvlist={}".format(", ".join(envlist)))

tests/unit/test_z_cmdline.py

@@ -280,6 +280,21 @@ def test_unknown_environment(cmd, initproj):
     assert result.out == "ERROR: unknown environment 'qpwoei'\n"
 
 
+def test_unknown_environment_with_envlist(cmd, initproj):
+    initproj(
+        "pkg123",
+        filedefs={
+            "tox.ini": """
+            [tox]
+            envlist = py{36,37}-django{20,21}
+        """
+        },
+    )
+    result = cmd("-e", "py36-djagno21")
+    assert result.ret, "{}\n{}".format(result.err, result.out)
+    assert result.out == "ERROR: unknown environment 'py36-djagno21'\n"
+
+
 def test_minimal_setup_py_empty(cmd, initproj):
     initproj(
         "pkg123-0.7",