-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include license file in the generated wheel package #1083
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't personally like updating unrelated files in a change that mentions something else.
It means that I should add myself to contributors document, even if I fix a missing comma?
Anyway, I am not aware about any policy that would forbit that so +1
The wheel package format supports including the license file. This is done using the [metadata] section in the setup.cfg file. For additional information on this feature, see: https://wheel.readthedocs.io/en/stable/user_guide.html#including-license-files-in-the-generated-wheel-file Helps project comply with its own license. > The above copyright notice and this permission notice shall be > included in all copies or substantial portions of the Software.
If you're saying I shouldn't add my name to Either way, I've rebased so my name is no longer being added as part of this change (it was included in a previous PR) |
We have no change amount needed to add it. It's fine to be added 👍 I'm not sure about this change, isn't it already added by |
Before this change, the
After this change it now also contains the file:
So, now the LICENSE file is distributed with the Further, the license contains the text:
The wheel package is a copy of the software. Therefore, it should contain the LICENSE text with its copyright. |
The wheel package format supports including the license file. This is done using the [metadata] section in the setup.cfg file. For additional information on this feature, see: https://wheel.readthedocs.io/en/stable/user_guide.html#including-license-files-in-the-generated-wheel-file Helps project comply with its own license. > The above copyright notice and this permission notice shall be > included in all copies or substantial portions of the Software.
The wheel package format supports including the license file. This is
done using the [metadata] section in the setup.cfg file. For additional
information on this feature, see:
https://wheel.readthedocs.io/en/stable/user_guide.html#including-license-files-in-the-generated-wheel-file
Helps project comply with its own license.
Contribution checklist:
(also see CONTRIBUTING.rst for details)
added/updated test(s)N/Aupdated/extended the documentationN/Aadded relevant issue keywordin message body
<issue number>.<type>.rst
for example (588.bugfix.rst)<type>
is must be one ofbugfix
,feature
,deprecation
,breaking
,doc
,misc
superuser
."CONTRIBUTORS
(preserving alphabetical order)