Fixed result of tox_get_python_executable not being used to make virtualenvs #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWhetter
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
gaborbernat
requested changes
May 15, 2019
|
Is this what you had in mind? |
|
Do fix the Ci (run tox -e fix_lint), otherwise looks great. |
gaborbernat
approved these changes
May 16, 2019
|
Released via https://pypi.org/project/tox/3.11.1/, thanks for your contribution.
|
|
Thank you so much for the fast feedback and fast release! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of
tox_get_python_executablehooks are again used to create the virtualenvs.Fixes #1300