Use POSIX shell rules for creating posargs string on non-Windows platforms

[barneygale]

subprocess.list2cmdline() uses Windows shell rules, which don't apply on Linux/Mac. This patch changes it to use pipes.quote() (py2) or shlex.quote() (py3)

Contribution checklist:

(also see CONTRIBUTING.rst for details)

• wrote descriptive pull request text
• added/updated test(s)
• updated/extended the documentation
• added relevant issue keyword
  in message body
• added news fragment in changelog folder
  • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
  • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
  • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
  • "sign" fragment with "by :user:<your username>"
  • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
  • also see examples
• added yourself to CONTRIBUTORS (preserving alphabetical order)

[gaborbernat]

Hello, thanks for the PR. Please add a changelog entry.

[barneygale]

I've completed the checklist except for docs, which I think might be unnecessary for this bugfix.

[gaborbernat]

Please run tox -e fix_lint to fix linting issues and commit 👍

[barneygale]

Lint issue looks like a CI setup issue to me: ModuleNotFoundError: No module named '_sqlite3'

[asottile]

https://github.com/microsoft/azure-pipelines-image-generation/issues/996 for that :/

[barneygale]

Would someone be willing to run fix_lint on this patch? My distribution only has 3.5 in official repos, whereas black requires 3.6+. Otherwise I can look at getting pyenv working.

[gaborbernat]

Sad for the CI break

but thank you for your contribution

[gaborbernat]

@asottile so all projects using pre-commit are then broken in Azure Pipelines?

[asottile]

all projects using sqlite3 are currently broken for python3.5 and python3.7 on azure pipelines -- and yeah :/ pre-commit happens to use sqlite

[barneygale]

Thanks for the review + merge. Can I ask when you might be making the next pypi release of tox?

[gaborbernat]

Can do as soon as Azure gets better 👍 so maybe subscribe to https://github.com/microsoft/azure-pipelines-image-generation/issues/996 😄

[barneygale]

Great, thank you!