Do not interpolate values from tox --showconfig #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albinvass
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
Currently --showconfig breaks if any '%' is present since configparser tries to interpolate that by default. Turn this off by using RawConfigParser instead which is supported in both python2 and python3. Resolves tox-dev#1584
albinvass
force-pushed
the
showconfig-interpolation
branch
from
8e30d4b to
8d000bb
Compare
ssbarnea
approved these changes
May 20, 2020
added 2 commits
May 20, 2020 11:42
gaborbernat
approved these changes
May 20, 2020
ssbarnea
pushed a commit
to ssbarnea/tox
that referenced
this pull request
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently --showconfig breaks if any '%' is present since configparser
tries to interpolate that by default.
Turn this off by using RawConfigParser instead which is supported in
both python2 and python3.
Resolves #1584