-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a HOSTNAME environment variable instead of socket.getfqdn() in ResultLog #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sultLog This makes it possible to prevent an undesired DNS query. Fixes tox-dev#1615
gaborbernat
approved these changes
Jul 14, 2020
Weird that the tests passed here, but when I try to package 3.17.0, I get:
|
Right, because when the HOSTNAME is |
hroncok
added a commit
to hroncok/tox
that referenced
this pull request
Jul 14, 2020
See tox-dev#1616 (comment) This is a fixup of cfe66fd.
4 tasks
Followup: #1618 |
hroncok
added a commit
to hroncok/tox
that referenced
this pull request
Jul 15, 2020
Use a pytest provided fixture instead of implementing our own. See tox-dev#1616 (comment) This is a fixup of cfe66fd.
hroncok
added a commit
to hroncok/tox
that referenced
this pull request
Jul 15, 2020
Use a pytest provided fixture instead of implementing our own. See tox-dev#1616 (comment) This is a fixup of cfe66fd.
asottile
pushed a commit
that referenced
this pull request
Jul 15, 2020
Use a pytest provided fixture instead of implementing our own. See #1616 (comment) This is a fixup of cfe66fd.
ssbarnea
pushed a commit
to ssbarnea/tox
that referenced
this pull request
Apr 19, 2021
…sultLog (tox-dev#1616) This makes it possible to prevent an undesired DNS query. Fixes tox-dev#1615
ssbarnea
pushed a commit
to ssbarnea/tox
that referenced
this pull request
Apr 19, 2021
Use a pytest provided fixture instead of implementing our own. See tox-dev#1616 (comment) This is a fixup of cfe66fd.
amoralej
pushed a commit
to rdo-common/pyproject-rpm-macros
that referenced
this pull request
Jun 30, 2022
Tox calls socket.getfqdn() and that call does a DNS query. In mock with disabled networking, it takes a minute until that times out. When a spec file uses %pyproject_buildrequires -t and %tox, it is a 3 minute delay. Since 3.17, tox does not call socket.getfqdn() when HOSTNAME variable is set to a value: tox-dev/tox#1616 The value is only used in result log, so setting it to "rpmbuild" actually makes the logs more reproducible as well. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1856356 when tox is used in %pyproject_buildrequires -t or %tox.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to prevent an undesired DNS query.
Fixes #1615
Thanks for contributing a pull request!
If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.
Contribution checklist:
(also see CONTRIBUTING.rst for details)
CONTRIBUTORS
(preserving alphabetical order)Not quite sure where to document this behavior.