-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hash / number sign cannot be escaped in tox.ini #181
Comments
1 similar comment
Original comment by @hpk42 Fixes bug 181; allow # in commands If a # was in a command the original code naively removed it and This fix is backward incompatible because it no longer allows a → <<cset 267db03b41e9>> |
Original comment by @dstanek I created a fix and submitted a pull request for this: https://bitbucket.org/hpk42/tox/pull-requests/174 |
Original comment by ludwigf The current parser does ignore everything after # without a way to escape it. Good for:
Bad for:
|
Original comment by @hpk42 Is this a problem for "deps" specifically? Just tried putting "#" in commands and that didn't cause problems. IOW, do you have a specific example? (i agree we should probably go do things similar as the default parser but doing that now might break existing tox.ini files so i'd like to see how we can best advance now). |
I can't tell what the disposition of this is, but in my testing, it's still an issue. I used this tox testenv:
And I get this output:
My actual use-case is I want to pass a URL template to a command, a URL with a fragment:
Is there a way to put |
I found the answer in this stackoverflow answer. Wrap the result in
|
The tox.ini parser does not provide a way to use the #-character as it is always interpreted as comment-begin.
The built-in python ini parser avoids the problem altogether by allowing comments to only start at line beginning.
With pip urls often containing the character this breaks several use cases.
The text was updated successfully, but these errors were encountered: