Allow building with setuptools_scm 6+ #1984
Conversation
Once again a new setuptools_scm version is available, 6. Lets' not change this to <7 again but allow any future version. If it breaks in the future, we can adapt.
hroncok
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
| @@ -0,0 +1 @@ | |||
| Enable building tox with ``setuptools_scm`` 6+ by :user:hroncok | |||
There was a problem hiding this comment.
@hroncok you forgot the backticks after :user: ☝️
There was a problem hiding this comment.
Oh, not again. If only a machine could tell me this before this was merged 🤔
There was a problem hiding this comment.
/me needs to teach chronographer parse RST maybe
There was a problem hiding this comment.
Even simpler, https://github.com/tox-dev/tox/blob/master/.pre-commit-config.yaml#L56-L66 can have a simple regex rule in there 🤷🏻
There was a problem hiding this comment.
@gaborbernat I also thought so and I'm trying to explore this. But then I started to think about cases when the person doesn't want to mark themselves as an author and it got rather complicated...
There was a problem hiding this comment.
It doesn't have to be a must-have field, but just check for typos with it 🤔
There was a problem hiding this comment.
Yeah.. You're right. I overengineered it, I guess: #1990.
Once again a new setuptools_scm version is available, 6.
Lets' not change this to
<7again but allow any future version.If it breaks in the future, we can adapt.