Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve listenvs behaviour (list completely dynamic environments) #505

Closed
obestwalter opened this issue Apr 18, 2017 · 8 comments
Closed
Assignees
Labels
area:configuration area:reporting help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted. level:hard rought estimate that this might be quite hard to implement
Milestone

Comments

@obestwalter
Copy link
Member

obestwalter commented Apr 18, 2017

#271 missed one possible way of creating environments (completely dynamic just by referencing it in testenv).

[tox]
skipsdist = true

[testenv]
commands =
    dynamicenv: tox --version

tox -a:

python

It shows only the python env which seems to be the standard environment if nothing is defined. This is surprising as IMO creating an env this way is perfectly valid and should behave the same as if I listed it in envlist ...

Expected behaviour would be:

tox -a:

dynamicenv
@obestwalter obestwalter added bug and removed bug labels Apr 18, 2017
@hpk42
Copy link

hpk42 commented Apr 18, 2017 via email

@gaborbernat
Copy link
Member

how can that dynamic environment be even invoked?

@obestwalter
Copy link
Member Author

Right now we are not detecting them directly but you also can not specify them: "tox -e BLABLUB" gives you "unknown environment".

Moreover, "dynamicenv" might just be a factor and not a full environment name.

o.k. two showstoppers then basically. Looks like we better put this to an early grave then ...

how can that dynamic environment be even invoked?

The same way 'normal' environments are invoked: the example above woulde be invoked with tox -e dynamicenv.

@obestwalter
Copy link
Member Author

Moreover, "dynamicenv" might just be a factor and not a full environment name.

Just realized that this is not really a showstopper, as we are accounting for that already: you can attach a description to a factor, so this would be not a hindrance. Maybe there is hope ....

@obestwalter obestwalter reopened this Apr 19, 2017
@gaborbernat
Copy link
Member

another way we miss environments (I just found out is):

[tox]
envlist = py27

[testenv]
passenv = BAS_PROXY http_proxy https_proxy no_proxy
basepython = py27: python2.7
             magic: magic

here magic is not added 🤔

@obestwalter
Copy link
Member Author

That is the same thing though as the dynamicenv example (only defined in a different place). Basically you can create environments wherever just by referencing them.

@gaborbernat
Copy link
Member

will take a look at why these are missing 👍

@obestwalter obestwalter added area:configuration area:reporting level:hard rought estimate that this might be quite hard to implement and removed enhancement labels Sep 4, 2017
@gaborbernat gaborbernat self-assigned this Oct 9, 2017
@gaborbernat gaborbernat added this to the 3.5 milestone Sep 18, 2018
@gaborbernat gaborbernat modified the milestones: 3.5, 3.6 Oct 8, 2018
@gaborbernat gaborbernat modified the milestones: 3.6, 3.7 Dec 16, 2018
@gaborbernat gaborbernat added the help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted. label May 3, 2019
@gaborbernat
Copy link
Member

This now has been implemented with tox 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:configuration area:reporting help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted. level:hard rought estimate that this might be quite hard to implement
Projects
None yet
Development

No branches or pull requests

3 participants