-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hint for possible signal upon InvocationError #766
Conversation
Issue tox-dev#290. Co-authored-by: Daniel Hahler <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #766 +/- ##
==========================================
+ Coverage 94.82% 94.84% +0.01%
==========================================
Files 11 11
Lines 2397 2405 +8
==========================================
+ Hits 2273 2281 +8
Misses 124 124
Continue to review full report at Codecov.
|
The
The command |
@gaborbernat thanks for merging. And the commit message could have been clearer:
Or was it not possible with github ? |
It's a squash merge on master 👍 |
@gaborbernat Isn't it possible on github to do the equivalent of |
This is a follow up to issue #760, with changes outlined in #760 (comment).
An indication for the potential signal received is given, with the method suggested by @asottile in #760 (comment).
Tests have been reworked with a new dependency:
pytest-mock
. This mainly allowed totest_z_cmdline.py
.indeed, the signal hint is given only on
posix
systems.monkeypatch
has been used to fake system: windows (os.name == 'nt'
) orposix
(os.name == 'posix'
)Should this PR be accepted, please merge squashing all commits into a single one, with message
hint for possible signal upon InvocationError + better tests
.