esm: remove --no-import-harmony-assertions

syg · tpoisseau · commit f5352f6e4577 · 2024-11-21T08:54:55.000+01:00
It is off by default now. PR-URL: nodejs#54890 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/node.cc b/src/node.cc
@@ -753,9 +753,6 @@ static ExitCode ProcessGlobalArgsInternal(std::vector<std::string>* args,
                 "--no-harmony-import-attributes") == v8_args.end()) {
     v8_args.emplace_back("--harmony-import-attributes");
   }
-  // TODO(nicolo-ribaudo): remove this once V8 doesn't enable it by default
-  // anymore.
-  v8_args.emplace_back("--no-harmony-import-assertions");
 
   auto env_opts = per_process::cli_options->per_isolate->per_env;
   if (std::find(v8_args.begin(), v8_args.end(),

Original file line number	Diff line number	Diff line change
`@@ -753,9 +753,6 @@ static ExitCode ProcessGlobalArgsInternal(std::vector<std::string>* args,`
`753`	`753`	`"--no-harmony-import-attributes") == v8_args.end()) {`
`754`	`754`	`v8_args.emplace_back("--harmony-import-attributes");`
`755`	`755`	`}`
`756`		`- // TODO(nicolo-ribaudo): remove this once V8 doesn't enable it by default`
`757`		`- // anymore.`
`758`		`- v8_args.emplace_back("--no-harmony-import-assertions");`
`759`	`756`
`760`	`757`	`auto env_opts = per_process::cli_options->per_isolate->per_env;`
`761`	`758`	`if (std::find(v8_args.begin(), v8_args.end(),`