From c47bb862b5b98e9d14801cff88800a029ebdab9b Mon Sep 17 00:00:00 2001 From: Akshay Gupta Date: Tue, 16 Aug 2022 16:35:50 +0530 Subject: [PATCH] Allow only string msgs when rendering flashes to avoid phantom alerts --- app/views/layouts/application.html.erb | 2 +- app/views/layouts/signed_in_application.html.erb | 2 -- app/views/shared/_flash.html.erb | 4 ++-- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index f464c6e8d..33cafebd0 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -20,7 +20,7 @@
- + diff --git a/app/views/layouts/signed_in_application.html.erb b/app/views/layouts/signed_in_application.html.erb index a21facc25..a1e8c44ae 100644 --- a/app/views/layouts/signed_in_application.html.erb +++ b/app/views/layouts/signed_in_application.html.erb @@ -18,8 +18,6 @@ -<%#= yield :exceptions %> -
<%= render partial: 'shared/sidebar' %>
diff --git a/app/views/shared/_flash.html.erb b/app/views/shared/_flash.html.erb index fbea9f190..b3b72fc49 100644 --- a/app/views/shared/_flash.html.erb +++ b/app/views/shared/_flash.html.erb @@ -1,5 +1,5 @@
- <% flash.each do |name, msg| %> + <% flash.select { |_, msg| msg.is_a?(String) }.each do |name, msg| %>
@@ -8,7 +8,7 @@ - <%= content_tag :div, msg, :id => "flash_#{name}" if msg.is_a?(String) %> + <%= content_tag :div, msg, :id => "flash_#{name}" %>