Skip to content

Bring back SketchMapMonoid#sumOption #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jnievelt opened this issue Mar 31, 2014 · 2 comments · Fixed by #293
Closed

Bring back SketchMapMonoid#sumOption #292

jnievelt opened this issue Mar 31, 2014 · 2 comments · Fixed by #293
Labels
enhancement

Comments

@jnievelt
Copy link
Contributor

Looks like this got dropped with 09dbb9c
@jcoveney
Copy link
Contributor

Hmm! @cheecheeo any idea why this was dropped in the refactor?

@jnievelt jnievelt mentioned this issue Mar 31, 2014
Merged
@cheecheeo
Copy link
Contributor

  1. It didn't pass unit tests (at some point during development, maybe it does now).
  2. I had no performance tests to guarantee that it was still a performance improvement over the default implementation.

If it's needed bring it back bring it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restoring optimized SketchMapMonoid#sumOption twitter/algebird
3 participants
@cheecheeo @jcoveney @jnievelt