conan-io#182 Validate check_min_cppstd

Signed-off-by: Uilian Ries <[email protected]>

Author: uilianries

hooks/conan-center.py

@@ -387,11 +387,25 @@ def test(out):
 
     @run_test("KB-H046", output)
     def test(out):
-        if "check_min_cppstd" in conanfile_content and \
-            (not 'settings.get_safe("compiler.cppstd")' in conanfile_content and \
-            not "settings.get_safe('compiler.cppstd')" in conanfile_content):
-            out.error("'tools.check_min_cppstd requires 'if self.settings.get_safe(\"compiler.cppstd\")' first."
-                      "  Check if 'cppstd' is configured before 'check_min_cppstd'.")
+        def _which_line_is(content, lines):
+            n = 0
+            for line in lines:
+                n += 1
+                if content in line:
+                    return n
+            return 0
+
+        lines = conanfile_content.splitlines()
+        check_line = _which_line_is("check_min_cppstd", lines)
+        if check_line:
+            if_1_line = _which_line_is('settings.get_safe("compiler.cppstd")', lines)
+            if_2_line = _which_line_is("settings.get_safe('compiler.cppstd')", lines)
+            if (not if_1_line and not if_2_line) or \
+               (if_1_line and if_1_line > check_line) or \
+               (if_2_line and if_2_line > check_line):
+                out.error("'tools.check_min_cppstd requires 'if self.settings.get_safe(\"compiler.cppstd\")' first."
+                          "  Check if 'cppstd' is configured before 'check_min_cppstd'.")
+
 
 @raise_if_error_output
 def post_export(output, conanfile, conanfile_path, reference, **kwargs):

tests/test_hooks/conan-center/test_conan-center.py

@@ -611,6 +611,12 @@ def configure(self):
         output = self.conan(['create', '.', 'name/version@user/test'])
         self.assertIn("[VALIDATE CHECK_MIN_CPPSTD (KB-H046)] OK", output)
 
+        tools.save('conanfile.py', content=conanfile.replace("{0}", 'tools.check_min_cppstd(self, "11")')
+                   .replace("{1}", "if self.settings.get_safe(\"compiler.cppstd\"):\n            pass"))
+        output = self.conan(['create', '.', 'name/version@user/test'])
+        self.assertIn("ERROR: [VALIDATE CHECK_MIN_CPPSTD (KB-H046)] 'tools.check_min_cppstd requires 'if self.settings.get_safe(\"compiler.cppstd\")' first."
+                      "  Check if 'cppstd' is configured before 'check_min_cppstd'.", output)
+
         tools.save('conanfile.py', content=conanfile.replace("{0}", 'tools.check_min_cppstd(self, "11")').replace("{1}", ""))
         output = self.conan(['create', '.', 'name/version@user/test'])
         self.assertIn("ERROR: [VALIDATE CHECK_MIN_CPPSTD (KB-H046)] 'tools.check_min_cppstd requires 'if self.settings.get_safe(\"compiler.cppstd\")' first."