Use nested error message in 'queried for' assertions. Fixes #13

Munter · Munter · commit 9f92e04b36c9 · 2015-04-29T23:34:51.000+02:00
diff --git a/lib/index.js b/lib/index.js
@@ -403,18 +403,19 @@ module.exports = {
 
     expect.addAssertion(['HTMLDocument', 'HTMLElement'], 'queried for [first]', function (expect, subject, value) {
       var queryResult;
+
+      this.errorMode = 'nested';
+
       if (this.flags.first) {
         queryResult = subject.querySelector(value);
         if (!queryResult) {
-          this.errorMode = 'nested';
           expect.fail(function (output) {
             output.error('The selector').sp().jsString(value).sp().error('yielded no results');
           });
         }
       } else {
         queryResult = subject.querySelectorAll(value);
         if (queryResult.length === 0) {
-          this.errorMode = 'nested';
           expect.fail(function (output) {
             output.error('The selector').sp().jsString(value).sp().error('yielded no results');
           });
diff --git a/test/unexpected-dom.js b/test/unexpected-dom.js
@@ -372,6 +372,30 @@ describe('unexpected-dom', function () {
           '  The selector .blabla yielded no results'
       );
     });
+
+    it('should return an array-like NodeList', function () {
+      var document = jsdom.jsdom('<!DOCTYPE html><html><body><div></div><div></div><div></div></body></html>');
+
+      expect(document, 'queried for', 'div', 'to be a', 'DOMNodeList');
+    });
+
+    it('should be able to use array semantics', function () {
+      var document = jsdom.jsdom('<!DOCTYPE html><html><body><div></div><div></div><div></div></body></html>');
+
+      expect(document, 'queried for', 'div', 'to have length', 3);
+    });
+
+    it('should fail array checks with useful nested error message', function () {
+      var document = jsdom.jsdom('<!DOCTYPE html><html><body><div></div><div></div><div></div></body></html>');
+
+      expect(function () {
+        expect(document, 'queried for', 'div', 'to have length', 1);
+      }, 'to throw',
+          'expected <!DOCTYPE html><html><body>.........</body></html> queried for \'div\' to have length 1\n' +
+          '  expected NodeList[ <div></div>, <div></div>, <div></div> ] to have length 1\n' +
+          '    expected 3 to be 1'
+      );
+    });
   });
 
   describe('diffing', function () {
