Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that all plugins are upgraded to be compatible with v10 #215

Closed
15 tasks done
sunesimonsen opened this issue Oct 3, 2015 · 8 comments
Closed
15 tasks done
Milestone

Comments

@sunesimonsen
Copy link
Member

Almost all plugins needs to be upgraded and will probably only be compatible with v10.

  • unexpected-color
  • unexpected-couchdb
  • unexpected-dom
  • unexpected-exif
  • unexpected-express
  • unexpected-fs
  • unexpected-http
  • unexpected-image
  • unexpected-knockout
  • unexpected-messy
  • unexpected-mitm
  • unexpected-react-shallow
  • unexpected-resemble
  • unexpected-sinon
  • unexpected-stream
@sunesimonsen sunesimonsen added this to the v10 milestone Oct 3, 2015
@papandreou
Copy link
Member

Went through all of "my" plugins and unexpected-sinon, updated them to the v10 addAssertion syntax and saw that the test suites work. Some of the plugins, especially unexpected-messy and unexpected-sinon, could take greater advantage of the v10 features by splitting up assertions with optional parameters, but I haven't picked that up.

My changes have been pushed to an unexpected-v10 branch in each project.

@sunesimonsen
Copy link
Member Author

@papandreou awesome work!

@papandreou
Copy link
Member

Seems like all the plugins listed here are ready now in the sense that it has been validated that they work without any changes, or that they have a PR or an unexpected-v10 branch that prepare them.

What remains is to release new versions of each.

@papandreou
Copy link
Member

@sunesimonsen and I released new major versions of all the plugins on the list, except:

@papandreou
Copy link
Member

Unexpected-couchdb and unexpected-dom have been released now. Closing.

@bruderstein
Copy link
Contributor

I'll release unexpected-react-shallow late tonight.

@papandreou
Copy link
Member

@bruderstein What an atmospheric way to build up suspense around the release :)

@bruderstein
Copy link
Contributor

...aaaaaaand released :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants