Check for zip slip

urielsalis · urielsalis · commit 526fff64cb18 · 2021-05-12T01:28:33.000+02:00
diff --git a/src/main/kotlin/me/urielsalis/mccrashlib/deobfuscator/Deobfuscator.kt b/src/main/kotlin/me/urielsalis/mccrashlib/deobfuscator/Deobfuscator.kt
@@ -50,7 +50,7 @@ fun isZipSlip(version: String): Boolean {
     val canonicalDestinationDir = mappingsFile.canonicalPath
     val destinationFile = File(mappingsFile, version)
     val canonicalDestinationFile = destinationFile.canonicalPath
-    return canonicalDestinationFile.startsWith(canonicalDestinationDir + File.separator)
+    return !canonicalDestinationFile.startsWith(canonicalDestinationDir + File.separator)
 }
 
 private fun downloadMapping(version: String, name: String, isClient: Boolean) {

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ fun isZipSlip(version: String): Boolean {`
`50`	`50`	`val canonicalDestinationDir = mappingsFile.canonicalPath`
`51`	`51`	`val destinationFile = File(mappingsFile, version)`
`52`	`52`	`val canonicalDestinationFile = destinationFile.canonicalPath`
`53`		`- return canonicalDestinationFile.startsWith(canonicalDestinationDir + File.separator)`
	`53`	`+ return !canonicalDestinationFile.startsWith(canonicalDestinationDir + File.separator)`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`private fun downloadMapping(version: String, name: String, isClient: Boolean) {`