Merge pull request #75 from sylvestre/clippy

Some clippy fixes

Author: cakebaker

examples/arch.rs

@@ -3,11 +3,11 @@
 
 // spell-checker:ignore (API) nodename osname sysname
 
-use platform_info::*;
+use platform_info::{PlatformInfo, PlatformInfoAPI, UNameAPI};
 
 fn main() {
     let info = PlatformInfo::new().unwrap_or_else(|err| {
-        eprintln!("Unable to determine platform info: {}", err);
+        eprintln!("Unable to determine platform info: {err}");
         std::process::exit(1);
     });
     println!(

examples/ex.rs

@@ -3,7 +3,7 @@
 
 // spell-checker:ignore (API) nodename osname sysname
 
-use platform_info::*;
+use platform_info::{PlatformInfo, PlatformInfoAPI, UNameAPI};
 
 fn main() {
     let info = PlatformInfo::new().expect("Unable to determine platform info");

src/lib_impl.rs

@@ -11,7 +11,7 @@ use std::path::PathBuf;
 
 /// Standard thread-safe error type
 pub type ThreadSafeStdError = dyn std::error::Error + Send + Sync;
-/// Standard thread-safe error type (boxed to allow translation for any std::error::Error type)
+/// Standard thread-safe error type (boxed to allow translation for any `std::error::Error` type)
 pub type BoxedThreadSafeStdError = Box<ThreadSafeStdError>;
 
 /// A slice of a path string

src/platform/unix.rs

@@ -25,7 +25,7 @@ use std::fmt::{Debug, Formatter};
 
 use crate::{PlatformInfoAPI, PlatformInfoError, UNameAPI};
 
-use unix_safe::*;
+use unix_safe::{oss_from_cstr, utsname};
 
 // PlatformInfo
 /// Handles initial retrieval and holds cached information for the current platform (a Unix-like OS in this case).
@@ -162,7 +162,7 @@ impl PartialEq for UTSName {
             target_os = "netbsd"
         )))]
         {
-            equal = equal && (self.0.domainname == other.0.domainname)
+            equal = equal && (self.0.domainname == other.0.domainname);
         }
         equal
     }
@@ -181,7 +181,7 @@ mod unix_safe {
     use std::os::unix::ffi::OsStrExt;
 
     // oss_from_str()
-    /// *Returns* an OsString created from a libc::c_char slice.
+    /// *Returns* an `OsString` created from a `libc::c_char` slice.
     pub fn oss_from_cstr(slice: &[libc::c_char]) -> OsString {
         assert!(slice.len() < usize::try_from(isize::MAX).unwrap());
         assert!(slice.iter().position(|&c| c == 0 /* NUL */).unwrap() < slice.len());
@@ -219,7 +219,7 @@ fn test_osname() {
 #[test]
 fn structure_clone() {
     let info = PlatformInfo::new().unwrap();
-    println!("{:?}", info);
+    println!("{info:?}");
     #[allow(clippy::redundant_clone)] // ignore `clippy::redundant_clone` warning for direct testing
     let info_copy = info.clone();
     assert_eq!(info_copy, info);

tests/integration_test.rs

@@ -50,7 +50,7 @@ fn platform_clone() -> Result<(), String> {
     let info = PlatformInfo::new().unwrap();
     #[allow(clippy::redundant_clone)] // ignore `clippy::redundant_clone` warning for direct testing
     let info_copy = info.clone();
-    println!("{:?}", info);
+    println!("{info:?}");
     assert_eq!(info_copy, info);
     Ok(())
 }