Skip to content

Commit e5f01ba

Browse files
szuendCommit Bot
authored and
Commit Bot
committedMar 13, 2019
[cleanup] Remove unused stack_trace_ member from PromiseRejectMessage
[email protected] Bug: v8:8742 Change-Id: I307097021893617ed5178f1e967f9360a55cd929 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1520710 Auto-Submit: Simon Zünd <[email protected]> Commit-Queue: Yang Guo <[email protected]> Reviewed-by: Yang Guo <[email protected]> Cr-Commit-Position: refs/heads/master@{#60221}
1 parent b186976 commit e5f01ba

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed
 

‎include/v8.h

+2-6
Original file line numberDiff line numberDiff line change
@@ -6717,11 +6717,8 @@ enum PromiseRejectEvent {
67176717
class PromiseRejectMessage {
67186718
public:
67196719
PromiseRejectMessage(Local<Promise> promise, PromiseRejectEvent event,
6720-
Local<Value> value, Local<StackTrace> stack_trace)
6721-
: promise_(promise),
6722-
event_(event),
6723-
value_(value),
6724-
stack_trace_(stack_trace) {}
6720+
Local<Value> value)
6721+
: promise_(promise), event_(event), value_(value) {}
67256722

67266723
V8_INLINE Local<Promise> GetPromise() const { return promise_; }
67276724
V8_INLINE PromiseRejectEvent GetEvent() const { return event_; }
@@ -6731,7 +6728,6 @@ class PromiseRejectMessage {
67316728
Local<Promise> promise_;
67326729
PromiseRejectEvent event_;
67336730
Local<Value> value_;
6734-
Local<StackTrace> stack_trace_;
67356731
};
67366732

67376733
typedef void (*PromiseRejectCallback)(PromiseRejectMessage message);

‎src/isolate.cc

+1-6
Original file line numberDiff line numberDiff line change
@@ -4418,13 +4418,8 @@ void Isolate::ReportPromiseReject(Handle<JSPromise> promise,
44184418
Handle<Object> value,
44194419
v8::PromiseRejectEvent event) {
44204420
if (promise_reject_callback_ == nullptr) return;
4421-
Handle<FixedArray> stack_trace;
4422-
if (event != v8::kPromiseHandlerAddedAfterReject && value->IsJSObject()) {
4423-
stack_trace = GetDetailedStackTrace(Handle<JSObject>::cast(value));
4424-
}
44254421
promise_reject_callback_(v8::PromiseRejectMessage(
4426-
v8::Utils::PromiseToLocal(promise), event, v8::Utils::ToLocal(value),
4427-
v8::Utils::StackTraceToLocal(stack_trace)));
4422+
v8::Utils::PromiseToLocal(promise), event, v8::Utils::ToLocal(value)));
44284423
}
44294424

44304425
void Isolate::SetUseCounterCallback(v8::Isolate::UseCounterCallback callback) {

0 commit comments

Comments
 (0)
Please sign in to comment.