changes after review

Co-authored-by: Mathieu <[email protected]>

Author: MelissaFrncJrg

Diff for: @vates/types/src/xo.mts

@@ -242,23 +242,23 @@ export type XoPool = BaseXapiXo & {
     cores?: number
     sockets?: number
   }
-  crashDumpSr: XoSr['id']
+  crashDumpSr?: XoSr['id']
   current_operations: Record<string, POOL_ALLOWED_OPERATIONS>
-  defaultSr: XoSr['id']
-  ha_enabled: boolean
-  haSrs: XoVdi['id'][]
+  defaultSr?: XoSr['id']
+  HA_enabled: boolean
+  haSrs: XoSr['id'][]
   id: Branded<'pool'>
   master: XoHost['id']
-  migrationCompression: boolean
+  migrationCompression?: boolean
   name_description: string
   name_label: string
-  other_config: Record<string, string>
+  otherConfig: Record<string, string>
   platform_version: string
-  suspendSr: XoSr['id']
+  suspendSr?: XoSr['id']
   tags: string[]
   type: 'pool'
   vtpmSupported: boolean
-  xosanPackInstallationTime: number
+  xosanPackInstallationTime: number | null
   zstdSupported: boolean
 }
 

Diff for: @xen-orchestra/rest-api/src/pools/pool.controller.mts

@@ -6,7 +6,7 @@ import { RestApi } from '../rest-api/rest-api.mjs'
 import { notFoundResp, unauthorizedResp, type Unbrand } from '../open-api/common/response.common.mjs'
 import type { WithHref } from '../helpers/helper.type.mjs'
 import { XapiXoController } from '../abstract-classes/xapi-xo-controller.mjs'
-import { XoPool } from '@vates/types'
+import type { XoPool } from '@vates/types'
 import { partialPools, pool, poolIds } from '../open-api/oa-examples/pool.oa-example.mjs'
 
 @Route('pools')