Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with rust 1.65 #30

Closed
glandium opened this issue Nov 4, 2022 · 0 comments · Fixed by #31
Closed

Issues with rust 1.65 #30

glandium opened this issue Nov 4, 2022 · 0 comments · Fixed by #31

Comments

@glandium
Copy link
Contributor

glandium commented Nov 4, 2022

Building Firefox with rust 1.65 leads to crashes in our test suites where fallible_collections::vec::vec_try_extend would hit the "Invalid layout" case in https://github.com/vcombey/fallible_collections/blob/master/src/vec.rs#L486 where it wouldn't with earlier versions of rust (most likely due to rust-lang/rust#95295)

Then I cloned the repo and just ran cargo test, which failed with SIGILL: illegal instruction on this backtrace:

#0  core::hint::unreachable_unchecked () at /rustc/897e37553bba8b42751c67658967889d11ecd120/library/core/src/hint.rs:103
#1  0x000055555556b3b0 in core::result::Result<core::alloc::layout::Layout, core::alloc::layout::LayoutError>::unwrap_unchecked<core::alloc::layout::Layout, core::alloc::layout::LayoutError> (self=...) at /rustc/897e37553bba8b42751c67658967889d11ecd120/library/core/src/result.rs:1530
#2  0x000055555557ad32 in alloc::raw_vec::RawVec<u8, alloc::alloc::Global>::current_memory<u8, alloc::alloc::Global> (self=0x7ffff663f7d8)
    at /rustc/897e37553bba8b42751c67658967889d11ecd120/library/alloc/src/raw_vec.rs:247
#3  0x000055555557e00b in alloc::raw_vec::{impl#3}::drop<u8, alloc::alloc::Global> (self=0x7ffff663f7d8)
    at /rustc/897e37553bba8b42751c67658967889d11ecd120/library/alloc/src/raw_vec.rs:478
#4  0x000055555557d87a in core::ptr::drop_in_place<alloc::raw_vec::RawVec<u8, alloc::alloc::Global>> ()
    at /rustc/897e37553bba8b42751c67658967889d11ecd120/library/core/src/ptr/mod.rs:487
#5  0x000055555557d6ab in core::ptr::drop_in_place<alloc::vec::Vec<u8, alloc::alloc::Global>> ()
    at /rustc/897e37553bba8b42751c67658967889d11ecd120/library/core/src/ptr/mod.rs:487
#6  0x000055555556e0db in fallible_collections::vec::tests::try_clone_oom () at src/vec.rs:829
#7  0x0000555555578f1a in fallible_collections::vec::tests::try_clone_oom::{closure#0} () at src/vec.rs:824
#8  0x000055555557d36e in core::ops::function::FnOnce::call_once<fallible_collections::vec::tests::try_clone_oom::{closure_env#0}, ()> ()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant