Skip to content

Can't use r.js (RequireJS) #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
markzrt opened this issue Oct 20, 2016 · 3 comments
Closed

Can't use r.js (RequireJS) #910

markzrt opened this issue Oct 20, 2016 · 3 comments

Comments

@markzrt
Copy link

markzrt commented Oct 20, 2016

when I write r.js or like the prompt disappears, and then displays an error

HyperTerm 0.7.1
Electron 1.2.8
darwin x64 16.0.0
@ekmartin
Copy link
Contributor

This is because it's recognized as a website URL. We should probably have some kind of check to make sure that the URL isn't a valid command before opening it in a webview.

@markzrt
Copy link
Author

markzrt commented Oct 20, 2016

Exactly, you're absolutely right...

@timothyis timothyis changed the title i can`t use r.js (RequireJS) Can't use r.js (RequireJS) Oct 21, 2016
@ppot ppot mentioned this issue Dec 17, 2016
Merged
@ppot ppot closed this as completed Dec 18, 2016
@rauchg
Copy link
Member

rauchg commented Dec 31, 2016

URL handling has been vastly improved on 1.0.1! Thanks for the reports 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rauchg @ekmartin @markzrt @ppot