Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodejs 7 buffer deprecation warning #234

Closed
alpertuna opened this issue Nov 4, 2016 · 4 comments
Closed

Nodejs 7 buffer deprecation warning #234

alpertuna opened this issue Nov 4, 2016 · 4 comments

Comments

@alpertuna
Copy link

Hi,
After upgrading nodejs to 7, I got this warning and wanted to report it.

DeprecationWarning: Using Buffer without `new` will soon stop working. Use `new Buffer()`, or preferably `Buffer.from()`, `Buffer.allocUnsafe()` or `Buffer.alloc()` instead.
@vitaly-t
Copy link
Owner

vitaly-t commented Nov 4, 2016

This warning relates to the underlying driver, and not immediately to this library. This will get resolved when the time is right. At the moment it is not, as the driver got a number of its own problems, and not really suitable for an upgrade. By the time that "soon" becomes "now" it will be resolved, somehow.

@alpertuna
Copy link
Author

I supposed Buffer is used by this library since I didn't look into source, that's why I just wanted to report it. Of course time is not problem as nodejs 7 is very new.
I would move the issue to main library but there is already reported one; brianc/node-postgres#1163

Btw, thanks for quick reply.

@MitMaro
Copy link

MitMaro commented Nov 28, 2016

Looks like this won't be an issue for at least node 7.

nodejs/node@4fffe32

@vitaly-t
Copy link
Owner

vitaly-t commented Dec 9, 2016

Version 7.2.1 of Node.js removed both the warning and the plans for making the change in 7.x 😄

Problem solved! 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants