Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): add column width stories, remove max-width #1715

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

dtsanevmw
Copy link
Contributor

@dtsanevmw dtsanevmw commented Feb 25, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

No visual tests.

Setting max-width on the control-container class which is not needed actually.

Issue Number: N/A

What is the new behavior?

Visual tests for column widths.

No max-width set.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Feb 25, 2025

👋 @dtsanevmw,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@dtsanevmw dtsanevmw marked this pull request as draft February 25, 2025 13:27
@dtsanevmw dtsanevmw changed the title fix(forms): add colum width stories, class binding, remove max-width fix(forms): add colum width stories, remove max-width Feb 26, 2025
@dtsanevmw dtsanevmw marked this pull request as ready for review February 26, 2025 08:55
Copy link
Contributor

This PR introduces visual changes: a800bdb
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/cde-2572
git fetch https://github.com/vmware-clarity/ng-clarity.git a800bdba3f21f14f908d05aed7bc7923f1975fb6
git cherry-pick a800bdba3f21f14f908d05aed7bc7923f1975fb6
git push

@dtsanevmw dtsanevmw requested a review from a team February 26, 2025 09:26
@valentin-mladenov valentin-mladenov changed the title fix(forms): add colum width stories, remove max-width fix(forms): add columн width stories, remove max-width Feb 26, 2025
@dtsanevmw dtsanevmw changed the title fix(forms): add columн width stories, remove max-width fix(forms): add column width stories, remove max-width Feb 26, 2025
Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtsanevmw dtsanevmw merged commit ec32f04 into main Feb 26, 2025
12 checks passed
@dtsanevmw dtsanevmw deleted the dtsanevmw/cde-2572 branch February 26, 2025 11:33
Copy link
Contributor

🎉 This PR is included in version 17.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants