Skip to content

fix(reactivity): extended methods respect reactive #11629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 16, 2024
Merged

fix(reactivity): extended methods respect reactive #11629

merged 6 commits into from
Aug 16, 2024
+16 −7

Conversation

edison1105
Copy link
Member

close #11628

andylizi and others added 2 commits August 15, 2024 10:28
@andylizi
fix(types/custom-element): defineCustomElement with required props (v…

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
GPG key ID: 64A196AEE0916D55
Verified
Learn about vigilant mode
Loading
Loading status checks…
77d5e88 
…uejs#11578)
@edison1105
fix(reactivity): extended methods respect reactive

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
f609446
@edison1105 edison1105 linked an issue Aug 16, 2024 that may be closed by this pull request
Computed values from extended array methods do not re-evaluate #11628
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 16, 2024 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 98.7 kB (+13 B) 37.4 kB (-3 B) 33.7 kB (+18 B)
vue.global.prod.js 156 kB (+13 B) 57.2 kB (-3 B) 50.9 kB (+50 B)

Usages

Name Size Gzip Brotli
createApp 54.2 kB (+13 B) 21 kB (+2 B) 19.1 kB (+7 B)
createSSRApp 58.1 kB (+13 B) 22.6 kB (+1 B) 20.6 kB (-5 B)
defineCustomElement 58.8 kB (+13 B) 22.5 kB 20.5 kB (+19 B)
overall 67.8 kB (+13 B) 26 kB (-2 B) 23.7 kB (-40 B)

@netlify Netlify
Copy link

netlify bot commented Aug 16, 2024 •
edited
Loading

❌ Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit 4ca5de7
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/66bf0ba3e228ca0008cd7dc0

@edison1105
chore: clean

Verified

This commit was signed with the committer’s verified signature. The key has expired.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
c32c53b
@edison1105
chore: update

Verified

This commit was signed with the committer’s verified signature. The key has expired.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
e6e6a27
@yyx990803 yyx990803 changed the base branch from minor to main August 16, 2024 07:59
@edison1105
Revert "fix(types/custom-element): defineCustomElement with require…

Verified

This commit was signed with the committer’s verified signature. The key has expired.
BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
80764e8 
…d props (vuejs#11578)"

This reverts commit 77d5e88.
@netlify Netlify
Copy link

netlify bot commented Aug 16, 2024 •
edited
Loading

❌ Deploy Preview for vue-next-template-explorer failed.

Name Link
🔨 Latest commit 4ca5de7
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/66bf0ba3faea2000092338cb

@yyx990803
chore: minor tweaks
Loading
Loading status checks…
4ca5de7
@yyx990803 yyx990803 merged commit 9de1d10 into vuejs:main Aug 16, 2024
6 of 11 checks passed
@linzhe141 linzhe141 mentioned this pull request Aug 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Computed values from extended array methods do not re-evaluate
3 participants
@edison1105 @yyx990803 @andylizi